Re: [PR] KAFKA-16036; Add `group.coordinator.rebalance.protocols` and publish all new configs [kafka]
dajac merged PR #15053: URL: https://github.com/apache/kafka/pull/15053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16036; Add `group.coordinator.rebalance.protocols` and publish all new configs [kafka]
dajac commented on PR #15053: URL: https://github.com/apache/kafka/pull/15053#issuecomment-1866183110 It is impossible to get a clean build at the moment. There are OOM errors all over the places, including in trunk. Looking at all the builds, it is clear that this PR does not create persistent failures. I also ran all the tests locally to confirm. Therefore, I will merge it to trunk and 3.7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16036; Add `group.coordinator.rebalance.protocols` and publish all new configs [kafka]
dajac commented on PR #15053: URL: https://github.com/apache/kafka/pull/15053#issuecomment-1864868557 @jeffkbkim The goal is to have something better than `group.coordinator.new.enable`. Yes, I will add it to the KIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16036; Add `group.coordinator.rebalance.protocols` and publish all new configs [kafka]
jeffkbkim commented on PR #15053: URL: https://github.com/apache/kafka/pull/15053#issuecomment-1864862018 is the purpose of this config to prevent EA users from accidentally using the consumer protocol while using the new coordinator? also, should we update the kip with this new config? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] KAFKA-16036; Add `group.coordinator.rebalance.protocols` and publish all new configs [kafka]
dajac opened a new pull request, #15053: URL: https://github.com/apache/kafka/pull/15053 This patch adds the `group.coordinator.rebalance.protocols` configuration which accepts a list of protocols to enable. At the moment, only `generic` and `consumer` are supported and it is not possible to disable `generic` yet. When `consumer` is enabled, the new consumer rebalance protocol (KIP-848) is enabled alongside the new group coordinator. This patch also publishes all the new configurations introduced by KIP-848. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
