Re: [PR] KAFKA-16052: create a real dummy replicaManager instance to save memory [kafka]
showuon closed pull request #15083: KAFKA-16052: create a real dummy replicaManager instance to save memory URL: https://github.com/apache/kafka/pull/15083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16052: create a real dummy replicaManager instance to save memory [kafka]
showuon commented on PR #15083: URL: https://github.com/apache/kafka/pull/15083#issuecomment-1871984181 > in this PR @divijvaidya , Good catch! We have to close replicaManager now since we're creating a real one. Let's use your commit for the fix. Please open a PR with this [commit](https://github.com/divijvaidya/kafka/commit/d4228a339035d83225408e5651e5cacbf604f0e8). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16052: create a real dummy replicaManager instance to save memory [kafka]
jolshan commented on PR #15083: URL: https://github.com/apache/kafka/pull/15083#issuecomment-1871343921 I had also started an attempt of this and was trying to get the produce purgatory to be hooked up as expected. I also had some issues with passing nulls into the optional arguments. (But maybe I was doing something wrong) I'm happy to review this or Divij's commits. Let's agree to focus on one PR though :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16052: create a real dummy replicaManager instance to save memory [kafka]
divijvaidya commented on PR #15083: URL: https://github.com/apache/kafka/pull/15083#issuecomment-1871218253 Hey @showuon There are multiple other things that need to be corrected with this test, such as closing metrics, ensuring that producePurgatory is being closed etc. Also, the change you proposed does not reset the mock of LogManager after every test. Hence, I have taken the liberty of creating a commit with a bunch of more changes: https://github.com/divijvaidya/kafka/commit/d4228a339035d83225408e5651e5cacbf604f0e8 Please feel free to implement the changes in this PR or cherry-pick the commit in this PR. Whatever is convenient for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
