Re: [PR] KAFKA-16146: Checkpoint log-start-offset for remote log enabled topics [kafka]

[via GitHub]

satishd merged PR #15201:
URL: https://github.com/apache/kafka/pull/15201


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16146: Checkpoint log-start-offset for remote log enabled topics [kafka]

[via GitHub]

satishd commented on PR #15201:
URL: https://github.com/apache/kafka/pull/15201#issuecomment-1987943134

   Merging the changes as the test failures are unrelated to this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16146: Checkpoint log-start-offset for remote log enabled topics [kafka]

[via GitHub]

satishd commented on code in PR #15201:
URL: https://github.com/apache/kafka/pull/15201#discussion_r1519366268


##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -865,7 +865,8 @@ class LogManager(logDirs: Seq[File],
 try {
   logStartOffsetCheckpoints.get(logDir).foreach { checkpoint =>
 val logStartOffsets = logsToCheckpoint.collect {
-  case (tp, log) if log.logStartOffset > 
log.logSegments.asScala.head.baseOffset => tp -> log.logStartOffset
+  case (tp, log) if log.remoteLogEnabled() || log.logStartOffset > 
log.logSegments.asScala.head.baseOffset =>

Review Comment:
   Note: This change makes sure we always store the respective 
`log-start-offset` for tiered storage enabled topics.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16146: Checkpoint log-start-offset for remote log enabled topics [kafka]

[via GitHub]

kamalcph commented on PR #15201:
URL: https://github.com/apache/kafka/pull/15201#issuecomment-1986704478

   rebased the patch with trunk. The failed tests are unrelated. 
   
   cc @junrao @satishd 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16146: Checkpoint log-start-offset for remote log enabled topics [kafka]

[via GitHub]

kamalcph commented on PR #15201:
URL: https://github.com/apache/kafka/pull/15201#issuecomment-1894989811

   Test failures are unrelated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] KAFKA-16146: Checkpoint log-start-offset for remote log enabled topics [kafka]

[via GitHub]

kamalcph opened a new pull request, #15201:
URL: https://github.com/apache/kafka/pull/15201

   The log-start-offset was not getting flushed to the checkpoint file due to 
the check where we compare the log-start-offset with the localLog first segment 
base offset.
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org