Re: [PR] KAFKA-16179; Stop processing requests before stopping publishing [kafka]
github-actions[bot] commented on PR #15242: URL: https://github.com/apache/kafka/pull/15242#issuecomment-2116563410 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16179; Stop processing requests before stopping publishing [kafka]
jeffkbkim commented on code in PR #15242: URL: https://github.com/apache/kafka/pull/15242#discussion_r1491990746 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -481,6 +481,8 @@ class ControllerServer( CoreUtils.swallow(registrationChannelManager.shutdown(), this) registrationChannelManager = null } + if (socketServer != null) Review Comment: should we add a comment like we do in KafkaServer and BrokerServer? ``` // Stop socket server to stop accepting any more connections and requests. // Socket server will be shutdown towards the end of the sequence. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
