Re: [PR] KAFKA-16283: notify users about RoundRobinPartitioner bug [kafka]
showuon closed pull request #15400: KAFKA-16283: notify users about RoundRobinPartitioner bug URL: https://github.com/apache/kafka/pull/15400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16283: notify users about RoundRobinPartitioner bug [kafka]
showuon commented on PR #15400: URL: https://github.com/apache/kafka/pull/15400#issuecomment-1958464961 Sorry @stanislavkozlovski , I just found this issue has already found and documented on document. Let's close this PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16283: notify users about RoundRobinPartitioner bug [kafka]
stanislavkozlovski commented on code in PR #15400:
URL: https://github.com/apache/kafka/pull/15400#discussion_r1497261719
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -297,7 +297,8 @@ public class ProducerConfig extends AbstractConfig {
" 1) If no partition is specified but a key is present, choose
a partition based on a hash of the key." +
" 2) If no partition or key is present, choose the sticky
partition that changes when at least " + BATCH_SIZE_CONFIG + " bytes are
produced to the partition." +
"" +
-
"org.apache.kafka.clients.producer.RoundRobinPartitioner: A
partitioning strategy where " +
+
"org.apache.kafka.clients.producer.RoundRobinPartitioner:
Please do not use this because of a serious bug found " +
+"that the partitioner will only send to half of the partitions.
See KAFKA-16283 for more detail. A partitioning strategy where " +
Review Comment:
nit: link to the jira?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] KAFKA-16283: notify users about RoundRobinPartitioner bug [kafka]
stanislavkozlovski commented on code in PR #15400: URL: https://github.com/apache/kafka/pull/15400#discussion_r1497263980 ## docs/upgrade.html: ## @@ -34,6 +34,8 @@ Notable changes in 3 Kafka Streams ships multiple KIPs for IQv2 support. See the Kafka Streams upgrade section for more details. +A serious bug found in RoundRobinPartitioner that it will only send to half of the partitions. Review Comment: ```suggestion A serious bug found in the producer's RoundRobinPartitioner has it send data to only half of the partitions, going completely against its goal of sending data in a round-robin way to all partitions. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] KAFKA-16283: notify users about RoundRobinPartitioner bug [kafka]
showuon opened a new pull request, #15400: URL: https://github.com/apache/kafka/pull/15400 Add notes in "3.7.0 notable changes" and "config doc" to notify users not to use `RoundRobinPartitioner`. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
