Re: [PR] KAFKA-16392: Stop emitting warning log message when parsing source connector offsets with null partitions [kafka]

[via GitHub]

C0urante merged PR #15562:
URL: https://github.com/apache/kafka/pull/15562


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16392: Stop emitting warning log message when parsing source connector offsets with null partitions [kafka]

[via GitHub]

C0urante commented on PR #15562:
URL: https://github.com/apache/kafka/pull/15562#issuecomment-2009913326

   Tests pass locally and this change is trivial; going to merge...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16392: Stop emitting warning log message when parsing source connector offsets with null partitions [kafka]

[via GitHub]

C0urante commented on code in PR #15562:
URL: https://github.com/apache/kafka/pull/15562#discussion_r1532337351


##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetUtilsTest.java:
##
@@ -134,6 +134,16 @@ public void testProcessPartitionKeyValidList() {
 }
 }
 
+@Test
+public void testProcessPartitionKeyNullOffset() {

Review Comment:
   Good catch 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16392: Stop emitting warning log message when parsing source connector offsets with null partitions [kafka]

[via GitHub]

yashmayya commented on code in PR #15562:
URL: https://github.com/apache/kafka/pull/15562#discussion_r1532113435


##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetUtilsTest.java:
##
@@ -134,6 +134,16 @@ public void testProcessPartitionKeyValidList() {
 }
 }
 
+@Test
+public void testProcessPartitionKeyNullOffset() {

Review Comment:
   I think this should be `testProcessPartitionKeyNullPartition` instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16392: Stop emitting warning log message when parsing source connector offsets with null partitions [kafka]

[via GitHub]

C0urante commented on PR #15562:
URL: https://github.com/apache/kafka/pull/15562#issuecomment-2009601190

   @yashmayya @gharris1727 would either of you have a quick moment for this 
small patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] KAFKA-16392: Stop emitting warning log message when parsing source connector offsets with null partitions [kafka]

[via GitHub]

C0urante opened a new pull request, #15562:
URL: https://github.com/apache/kafka/pull/15562

   [Jira](https://issues.apache.org/jira/browse/KAFKA-16392)
   
   This is a pretty lightweight change; we wrap the warning log message for 
unrecognized source partition types in a null guard.
   
   One test is added to verify the fix that ensures no log messages are emitted 
in the affected scenario.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org