Re: [PR] KAFKA-16433: BeginningAndEndOffsets and OffsetsForTimes should send an event and return empty with zero timeout provided [kafka]

[via GitHub]

philipnee commented on PR #15688:
URL: https://github.com/apache/kafka/pull/15688#issuecomment-2090947138

   Hi @kirktrue - It was clearly documented why LegacyKafkaConsumer would do 
this, maybe it is because in some scenarios users want to update the position 
but actually don't care about the offset results.  This is the snippet from the 
LegacyKafkaConsumer code:
   ```
 // if timeout is set to zero, do not try to poll the network 
client at all
   // and return empty immediately; otherwise try to get the 
results synchronously
   // and throw timeout exception if it cannot complete in time
   if (timer.timeoutMs() == 0L)
   return result;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16433: BeginningAndEndOffsets and OffsetsForTimes should send an event and return empty with zero timeout provided [kafka]

[via GitHub]

kirktrue commented on PR #15688:
URL: https://github.com/apache/kafka/pull/15688#issuecomment-2048148062

   @philipnee—sorry I'm late to the party, but why do we submit the event to 
the queue when the timeout is 0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] KAFKA-16433: BeginningAndEndOffsets and OffsetsForTimes should send an event and return empty with zero timeout provided [kafka]

[via GitHub]

lucasbru merged PR #15688:
URL: https://github.com/apache/kafka/pull/15688


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] KAFKA-16433: BeginningAndEndOffsets and OffsetsForTimes should send an event and return empty with zero timeout provided [kafka]

[via GitHub]

philipnee opened a new pull request, #15688:
URL: https://github.com/apache/kafka/pull/15688

   beginningOrEndOffset and offsetforTimes should send a ListOffsetEvent and 
return empty results if the provided timeout is zero.
   
   A minor change to the mock timer with zero timeout in AsyncConsumerTest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org