Re: [PR] KAFKA-16739: Exclude protected members from aggregated release Javadocs [kafka]

2024-05-21 Thread via GitHub


gharris1727 merged PR #15940:
URL: https://github.com/apache/kafka/pull/15940


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-16739: Exclude protected members from aggregated release Javadocs [kafka]

2024-05-21 Thread via GitHub


gharris1727 commented on PR #15940:
URL: https://github.com/apache/kafka/pull/15940#issuecomment-2123422940

   Build passes, CI test failures appear unrelated, and this passes for me 
locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KAFKA-16739: Exclude protected members from aggregated release Javadocs [kafka]

2024-05-13 Thread via GitHub


gharris1727 commented on PR #15940:
URL: https://github.com/apache/kafka/pull/15940#issuecomment-2108552171

   Hi @ijuma @vvcephei @mjsax @mimaison PTAL at this documentation build 
change, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] KAFKA-16739: Exclude protected members from aggregated release Javadocs [kafka]

2024-05-13 Thread via GitHub


gharris1727 opened a new pull request, #15940:
URL: https://github.com/apache/kafka/pull/15940

   The `./gradlew javadoc` and `./gradlew aggregatedJavadoc` have separate 
configurations that should be kept in lockstep. These have diverged twice: 
#13633 and #1413 and have been converged once before: #10272 .
   
   This has the effect of making it so that the aggregatedJavadoc hides 
protected members, because that's currently the only divergence between these 
configurations. This was discussed and approved in #13633, but as the change 
was never reflected in the official documentation, it's possible that users 
have not yet noticed that protected members have been missing in the last 3 
minor releases.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org