Re: [PR] KAFKA-16967: NioEchoServer fails to register connection and causes flaky failure. [kafka]
chia7712 merged PR #16384: URL: https://github.com/apache/kafka/pull/16384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16967: NioEchoServer fails to register connection and causes flaky failure. [kafka]
frankvicky commented on PR #16384: URL: https://github.com/apache/kafka/pull/16384#issuecomment-2186497190 Hi @chia7712, I have run the failing test on both the trunk and the 16967 branch on my local machine, but I couldn't reproduce the failure. I also reviewed the failing test, and it seems that my changes are not related to the failing test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16967: NioEchoServer fails to register connection and causes flaky failure. [kafka]
frankvicky commented on PR #16384: URL: https://github.com/apache/kafka/pull/16384#issuecomment-2185692698 > @frankvicky could you please take a look at filed test? that may be related to this PR? > > ``` > org.opentest4j.AssertionFailedError: Condition not met within timeout 15000. Metric not updated failed-authentication-total expected:<1.0> but was:<24.0> ==> expected: but was: > 栈跟踪 > org.opentest4j.AssertionFailedError: Condition not met within timeout 15000. Metric not updated failed-authentication-total expected:<1.0> but was:<24.0> ==> expected: but was: >at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) >at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) >at app//org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63) >at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36) >at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214) >at app//org.apache.kafka.test.TestUtils.lambda$waitForCondition$3(TestUtils.java:397) >at app//org.apache.kafka.test.TestUtils.retryOnExceptionWithTimeout(TestUtils.java:445) >at app//org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:394) >at app//org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:378) >at app//org.apache.kafka.common.network.NioEchoServer.waitForMetrics(NioEchoServer.java:213) >at app//org.apache.kafka.common.network.NioEchoServer.verifyAuthenticationMetrics(NioEchoServer.java:172) >at app//org.apache.kafka.common.network.SslTransportLayerTest.testUnsupportedCiphers(SslTransportLayerTest.java:650) >at java.base@21.0.3/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) >at java.base@21.0.3/java.lang.reflect.Method.invoke(Method.java:580) > ``` I will take a look 😨 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] KAFKA-16967: NioEchoServer fails to register connection and causes flaky failure. [kafka]
chia7712 commented on PR #16384: URL: https://github.com/apache/kafka/pull/16384#issuecomment-2185672343 @frankvicky could you please take a look at filed test? that may be related to this PR? ``` org.opentest4j.AssertionFailedError: Condition not met within timeout 15000. Metric not updated failed-authentication-total expected:<1.0> but was:<24.0> ==> expected: but was: 栈跟踪 org.opentest4j.AssertionFailedError: Condition not met within timeout 15000. Metric not updated failed-authentication-total expected:<1.0> but was:<24.0> ==> expected: but was: at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) at app//org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63) at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36) at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214) at app//org.apache.kafka.test.TestUtils.lambda$waitForCondition$3(TestUtils.java:397) at app//org.apache.kafka.test.TestUtils.retryOnExceptionWithTimeout(TestUtils.java:445) at app//org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:394) at app//org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:378) at app//org.apache.kafka.common.network.NioEchoServer.waitForMetrics(NioEchoServer.java:213) at app//org.apache.kafka.common.network.NioEchoServer.verifyAuthenticationMetrics(NioEchoServer.java:172) at app//org.apache.kafka.common.network.SslTransportLayerTest.testUnsupportedCiphers(SslTransportLayerTest.java:650) at java.base@21.0.3/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) at java.base@21.0.3/java.lang.reflect.Method.invoke(Method.java:580) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] KAFKA-16967: NioEchoServer fails to register connection and causes flaky failure. [kafka]
frankvicky opened a new pull request, #16384: URL: https://github.com/apache/kafka/pull/16384 The issue involves the `NioEchoServer` crashing when attempting to register new connections due to a connection already being registered. This problem is specifically in the test methods(`testUngracefulRemoteCloseDuringHandshakeRead`, `testUngracefulRemoteCloseDuringHandshakeWrite`) handling ungraceful remote closes during the handshake. The test fails because the connection becomes unexpectedly idle and expires, leading to a timeout. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org