Re: [PR] KRaft upgrade tests should only use latest stable mv [kafka]

2024-03-21 Thread via GitHub


jolshan merged PR #15566:
URL: https://github.com/apache/kafka/pull/15566


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KRaft upgrade tests should only use latest stable mv [kafka]

2024-03-21 Thread via GitHub


jolshan commented on PR #15566:
URL: https://github.com/apache/kafka/pull/15566#issuecomment-2013196878

   For some reason the build retriggered for the description update. Given this 
is a system test change, I think we don't have to wait for the rebuild. Here is 
the old build for reference: 
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15566/1/pipeline


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KRaft upgrade tests should only use latest stable mv [kafka]

2024-03-21 Thread via GitHub


ahuang98 commented on PR #15566:
URL: https://github.com/apache/kafka/pull/15566#issuecomment-2013184498

   Thanks @jolshan, updated the description!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KRaft upgrade tests should only use latest stable mv [kafka]

2024-03-21 Thread via GitHub


jolshan commented on PR #15566:
URL: https://github.com/apache/kafka/pull/15566#issuecomment-2013167459

   Thanks for the fix -- small nit in the description. It's not that the 
version didn't exist, but that we couldn't run the command  (likely because 
there is no supported (stable) MV for 3.8).
   ```
Command '/opt/kafka-dev/bin/kafka-features.sh --bootstrap-server 
worker28:9092,worker29:9092,worker17:9092 upgrade --metadata 3.8' returned 
non-zero exit status 1.
 Supported metadata versions are 3.3-IV0, 3.3-IV1, 3.3-IV2, 3.3-IV3, 
3.4-IV0, 3.5-IV0, 3.5-IV1, 3.5-IV2, 3.6-IV0, 3.6-IV1, 3.6-IV2, 3.7-IV0, 
3.7-IV1, 3.7-IV2, 3.7-IV3, 3.7-IV4\n
```

If we allow setting a config to allow the unstable metadata version, that 
would work too. However, I don't think it is useful.
The change to only test the stable metadata version in this system test 
makes sense.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] KRaft upgrade tests should only use latest stable mv [kafka]

2024-03-20 Thread via GitHub


ahuang98 opened a new pull request, #15566:
URL: https://github.com/apache/kafka/pull/15566

   This should help us avoid testing MVs before the corresponding release 
exists.
   We revert back from testing 3.8 in this case since 3.7 is the current stable 
version.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org