Re: [PR] MINOR: ConsumerRebalanceListenerInvoker class and method visibility [kafka]
dajac merged PR #14931: URL: https://github.com/apache/kafka/pull/14931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: ConsumerRebalanceListenerInvoker class and method visibility [kafka]
kirktrue commented on PR #14931: URL: https://github.com/apache/kafka/pull/14931#issuecomment-1843227108 @dajac—failing tests appear unrelated. Do we need four green builds before merging? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: ConsumerRebalanceListenerInvoker class and method visibility [kafka]
kirktrue commented on PR #14931: URL: https://github.com/apache/kafka/pull/14931#issuecomment-1841792685 Four greys. Restarting build again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: ConsumerRebalanceListenerInvoker class and method visibility [kafka]
kirktrue closed pull request #14931: MINOR: ConsumerRebalanceListenerInvoker class and method visibility URL: https://github.com/apache/kafka/pull/14931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: ConsumerRebalanceListenerInvoker class and method visibility [kafka]
kirktrue commented on PR #14931: URL: https://github.com/apache/kafka/pull/14931#issuecomment-1841727258 Three yellows, one red. Restarting 爛 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: ConsumerRebalanceListenerInvoker class and method visibility [kafka]
kirktrue closed pull request #14931: MINOR: ConsumerRebalanceListenerInvoker class and method visibility URL: https://github.com/apache/kafka/pull/14931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: ConsumerRebalanceListenerInvoker class and method visibility [kafka]
kirktrue commented on PR #14931: URL: https://github.com/apache/kafka/pull/14931#issuecomment-1841152541 @philipnee can you add the `ctr` and `KIP-848` tags, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: ConsumerRebalanceListenerInvoker class and method visibility [kafka]
kirktrue commented on PR #14931: URL: https://github.com/apache/kafka/pull/14931#issuecomment-1841151662 @dajac This is the shared bit pulled out from #14640 as you'd requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINOR: ConsumerRebalanceListenerInvoker class and method visibility [kafka]
kirktrue opened a new pull request, #14931: URL: https://github.com/apache/kafka/pull/14931 For forthcoming changes, make this class and its methods public for use outside the package. Also fix a minor logging issue to include the object in the log, not its `Optional` wrapper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
