Re: [PR] MINOR: Don't log missing partitions at ERROR level [kafka]
chia7712 commented on PR #14579: URL: https://github.com/apache/kafka/pull/14579#issuecomment-1977349997 > Perhaps we should just lower the priority to INFO instead of ERROR? I do think it's nice to know when we create a new log directory. That makes sense to me. We can keep only `stateChangeLogger.info(s"Creating new partition $tp with topic id " + s"$topicId.")` to simplify PR. @splett2 WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Don't log missing partitions at ERROR level [kafka]
github-actions[bot] commented on PR #14579: URL: https://github.com/apache/kafka/pull/14579#issuecomment-1897729360 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Don't log missing partitions at ERROR level [kafka]
cmccabe commented on PR #14579: URL: https://github.com/apache/kafka/pull/14579#issuecomment-1771568882 Perhaps we should just lower the priority to INFO instead of ERROR? I do think it's nice to know when we create a new log directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINOR: Don't log missing partitions at ERROR level [kafka]
splett2 opened a new pull request, #14579: URL: https://github.com/apache/kafka/pull/14579 ### What We are logging missing partitions as errors in the `state.change.logger` which may be a bit alarming. There are valid cases where the partition may not exist, eg: partition reassignment. ### Testing Verified that ReassignPartitionsIntegrationTest logs partition reassignments at error without the patch and doesn't with the patch. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
