Re: [PR] MINOR: Ensure that DisplayName is set in all parameterized tests [kafka]

[via GitHub]

dajac merged PR #14850:
URL: https://github.com/apache/kafka/pull/14850


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Ensure that DisplayName is set in all parameterized tests [kafka]

[via GitHub]

mumrah commented on PR #14850:
URL: https://github.com/apache/kafka/pull/14850#issuecomment-1836803801

   I tried this in IntelliJ and I see the test name included in the individual 
test variation output. Looks great!
   
   https://github.com/apache/kafka/assets/55116/fac807f0-06f8-4237-be95-3f9777c73363";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: Ensure that DisplayName is set in all parameterized tests [kafka]

[via GitHub]

dajac commented on code in PR #14850:
URL: https://github.com/apache/kafka/pull/14850#discussion_r1407964777


##
core/src/test/scala/kafka/utils/TestInfoUtils.scala:
##
@@ -51,7 +51,7 @@ object TestInfoUtils {
   testInfo.getDisplayName().contains("quorum=zkMigration")
 }
   }
-  final val TestWithParameterizedQuorumName = "{displayName}.quorum={0}"
+  final val TestWithParameterizedQuorumName = 
"{displayName}.{argumentsWithNames}"

Review Comment:
   Changing this one to be aligned with 
https://github.com/apache/kafka/pull/14687.



##
tools/src/test/java/org/apache/kafka/tools/ToolsTestUtils.java:
##
@@ -42,7 +42,7 @@
 
 public class ToolsTestUtils {
 /** @see TestInfoUtils#TestWithParameterizedQuorumName()  */
-public static final String TEST_WITH_PARAMETERIZED_QUORUM_NAME = 
"{displayName}.quorum={0}";
+public static final String TEST_WITH_PARAMETERIZED_QUORUM_NAME = 
"{displayName}.{argumentsWithNames}";

Review Comment:
   Changing this one to be aligned with 
https://github.com/apache/kafka/pull/14687.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] MINOR: Ensure that DisplayName is set in all parameterized tests [kafka]

[via GitHub]

dajac opened a new pull request, #14850:
URL: https://github.com/apache/kafka/pull/14850

   This is a follow-up to https://github.com/apache/kafka/pull/14687 as we 
found out that some parameterized tests do not include the test method name in 
their name. For the context, the JUnit XML report does not include the name of 
the method by default but only rely on the display name provided.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org