Re: [PR] MINOR: Remove dev_version parameter from streams tests [kafka]
lucasbru merged PR #15874: URL: https://github.com/apache/kafka/pull/15874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Remove dev_version parameter from streams tests [kafka]
lucasbru commented on PR #15874: URL: https://github.com/apache/kafka/pull/15874#issuecomment-2099949443 https://confluent-kafka-branch-builder-system-test-results-v2.s3-us-west-2.amazonaws.com/trunk/2024-05-07--001./report.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Remove dev_version parameter from streams tests [kafka]
mjsax commented on PR #15874: URL: https://github.com/apache/kafka/pull/15874#issuecomment-2099036837 Triggered a system test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder-test/20/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Remove dev_version parameter from streams tests [kafka]
lucasbru commented on PR #15874: URL: https://github.com/apache/kafka/pull/15874#issuecomment-2097704867 @mjsax It does change, because we need to keep a list of tests (with parameters) that do not work with ARM. The `from_version` parameter does not change, because only old versions are affected. But the `to_version` parameter changed with every minor release. After removing the `to_version` parameter, we won't have to change the list again. Does that clarify the intent here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Remove dev_version parameter from streams tests [kafka]
mjsax commented on PR #15874: URL: https://github.com/apache/kafka/pull/15874#issuecomment-2097231440 Thanks for the PR. Makes sense. What I don't fully understand is, what you mean by `This simplifies testing downstream, since the test parameters do not change with every version.` > In particular, some tests downstream are blacklisted because they do not work with ARM. These lists need to be updated every time DEV_VERSION is bumped. Seems this does not change after this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINOR: Remove dev_version parameter from streams tests [kafka]
lucasbru opened a new pull request, #15874: URL: https://github.com/apache/kafka/pull/15874 In two streams tests, we are using the current snapshot version as a test parameter `to_version`, but as the only option. We can hardcode it. This simplifies testing downstream, since the test parameters do not change with every version. In particular, some tests downstream are blacklisted because they do not work with ARM. These lists need to be updated every time `DEV_VERSION` is bumped. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
