Re: [PR] MINOR: Remove the client side assignor from the ConsumerGroupHeartbeat API [kafka]
jolshan commented on code in PR #14469:
URL: https://github.com/apache/kafka/pull/14469#discussion_r1543175309
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -43,21 +43,6 @@
"about": "null if it didn't change since the last heartbeat; the
subscribed topic regex otherwise" },
{ "name": "ServerAssignor", "type": "string", "versions": "0+",
"nullableVersions": "0+", "default": "null",
"about": "null if not used or if it didn't change since the last
heartbeat; the server side assignor to use otherwise." },
-{ "name": "ClientAssignors", "type": "[]Assignor", "versions": "0+",
"nullableVersions": "0+", "default": "null",
Review Comment:
No worries! I think we can do a better job sharing this widely with the
community. I will think about how that can be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINOR: Remove the client side assignor from the ConsumerGroupHeartbeat API [kafka]
aiven-anton commented on code in PR #14469:
URL: https://github.com/apache/kafka/pull/14469#discussion_r1543168871
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -43,21 +43,6 @@
"about": "null if it didn't change since the last heartbeat; the
subscribed topic regex otherwise" },
{ "name": "ServerAssignor", "type": "string", "versions": "0+",
"nullableVersions": "0+", "default": "null",
"about": "null if not used or if it didn't change since the last
heartbeat; the server side assignor to use otherwise." },
-{ "name": "ClientAssignors", "type": "[]Assignor", "versions": "0+",
"nullableVersions": "0+", "default": "null",
Review Comment:
Oh my, now I feel dumb 😄 Thanks for pointing this out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINOR: Remove the client side assignor from the ConsumerGroupHeartbeat API [kafka]
jolshan commented on code in PR #14469:
URL: https://github.com/apache/kafka/pull/14469#discussion_r1543165416
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -43,21 +43,6 @@
"about": "null if it didn't change since the last heartbeat; the
subscribed topic regex otherwise" },
{ "name": "ServerAssignor", "type": "string", "versions": "0+",
"nullableVersions": "0+", "default": "null",
"about": "null if not used or if it didn't change since the last
heartbeat; the server side assignor to use otherwise." },
-{ "name": "ClientAssignors", "type": "[]Assignor", "versions": "0+",
"nullableVersions": "0+", "default": "null",
Review Comment:
It is an annotation. See in the spec
```
"latestVersionUnstable": true,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINOR: Remove the client side assignor from the ConsumerGroupHeartbeat API [kafka]
aiven-anton commented on code in PR #14469:
URL: https://github.com/apache/kafka/pull/14469#discussion_r1542514661
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -43,21 +43,6 @@
"about": "null if it didn't change since the last heartbeat; the
subscribed topic regex otherwise" },
{ "name": "ServerAssignor", "type": "string", "versions": "0+",
"nullableVersions": "0+", "default": "null",
"about": "null if not used or if it didn't change since the last
heartbeat; the server side assignor to use otherwise." },
-{ "name": "ClientAssignors", "type": "[]Assignor", "versions": "0+",
"nullableVersions": "0+", "default": "null",
Review Comment:
I hope it's ok to slide in with an informal question here. I'm also curious:
what's the source of truth for API stability?
Is it something we could work on adding as an annotation to the schema spec
files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINOR: Remove the client side assignor from the ConsumerGroupHeartbeat API [kafka]
dajac merged PR #14469: URL: https://github.com/apache/kafka/pull/14469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
