Re: [PR] MINOR: Use --no-daemon when building with Jenkins [kafka]
dajac closed pull request #15057: MINOR: Use --no-daemon when building with Jenkins URL: https://github.com/apache/kafka/pull/15057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Use --no-daemon when building with Jenkins [kafka]
github-actions[bot] commented on PR #15057: URL: https://github.com/apache/kafka/pull/15057#issuecomment-2011157584 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Use --no-daemon when building with Jenkins [kafka]
ijuma commented on code in PR #15057:
URL: https://github.com/apache/kafka/pull/15057#discussion_r1434339183
##
Jenkinsfile:
##
@@ -21,7 +21,7 @@ def doValidation() {
// Run all the tasks associated with `check` except for `test` - the latter
is executed via `doTest`
sh """
./retry_zinc ./gradlew -PscalaVersion=$SCALA_VERSION clean check -x test \
---profile --continue -PxmlSpotBugsReport=true -PkeepAliveMode="session"
+--no-daemon --profile --continue -PxmlSpotBugsReport=true
-PkeepAliveMode="session"
Review Comment:
We can probably remove `keepAliveMode` if we use `no-daemon`:
> keepAliveMode: configures the keep alive mode for the Gradle compilation
daemon - reuse improves start-up time. The values should be one of daemon or
session (the default is daemon). daemon keeps the daemon alive until it's
explicitly stopped while session keeps it alive until the end of the build
session. This currently only affects the Scala compiler, see
https://github.com/gradle/gradle/pull/21034 for a PR that attempts to do the
same for the Java compiler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] MINOR: Use --no-daemon when building with Jenkins [kafka]
dajac opened a new pull request, #15057: URL: https://github.com/apache/kafka/pull/15057 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
