Re: [PR] MINOR: Use project path instead of name for spotlessApplyModules in Gradle script [kafka]
C0urante merged PR #16177: URL: https://github.com/apache/kafka/pull/16177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Use project path instead of name for spotlessApplyModules in Gradle script [kafka]
chia7712 commented on PR #16177: URL: https://github.com/apache/kafka/pull/16177#issuecomment-2145630544 > does this seem reasonable to you? ya, that makes sense to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: Use project path instead of name for spotlessApplyModules in Gradle script [kafka]
C0urante commented on PR #16177: URL: https://github.com/apache/kafka/pull/16177#issuecomment-2145492208 @chia7712 does this seem reasonable to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINOR: Use project path instead of name for spotlessApplyModules in Gradle script [kafka]
C0urante opened a new pull request, #16177: URL: https://github.com/apache/kafka/pull/16177 For nested subprojects like `:connect:runtime`, the `project.name` field will only return the name of the leaf project, e.g., `runtime`, which can be ambiguous and confusing when reading and modifying the build script. The `project.path` field includes the fully-qualified name (e.g., `:connect:runtime`), which is unambiguous and hopefully easier to read. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org