Re: [PR] MINOR: move TimeRatio to server-common [kafka]

[via GitHub]

jeffkbkim commented on PR #15447:
URL: https://github.com/apache/kafka/pull/15447#issuecomment-1984216605

   closing as it will not be used in a package outside of `raft`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: move TimeRatio to server-common [kafka]

[via GitHub]

jeffkbkim closed pull request #15447: MINOR: move TimeRatio to server-common
URL: https://github.com/apache/kafka/pull/15447


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: move TimeRatio to server-common [kafka]

[via GitHub]

jeffkbkim commented on code in PR #15447:
URL: https://github.com/apache/kafka/pull/15447#discussion_r1511449004


##
raft/src/test/java/org/apache/kafka/raft/internals/TimeRatioTest.java:
##
@@ -17,6 +17,7 @@
 package org.apache.kafka.raft.internals;
 
 import org.apache.kafka.common.metrics.MetricConfig;
+import org.apache.kafka.server.metrics.TimeRatio;

Review Comment:
   thanks for the catch! moved the test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: move TimeRatio to server-common [kafka]

[via GitHub]

ijuma commented on code in PR #15447:
URL: https://github.com/apache/kafka/pull/15447#discussion_r1510515422


##
raft/src/test/java/org/apache/kafka/raft/internals/TimeRatioTest.java:
##
@@ -17,6 +17,7 @@
 package org.apache.kafka.raft.internals;
 
 import org.apache.kafka.common.metrics.MetricConfig;
+import org.apache.kafka.server.metrics.TimeRatio;

Review Comment:
   This test should move too, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org