Re: [PR] MINOR: register before touch in BrokerHeartbeatManager [kafka]

[via GitHub]

cmccabe merged PR #14934:
URL: https://github.com/apache/kafka/pull/14934


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINOR: register before touch in BrokerHeartbeatManager [kafka]

[via GitHub]

cmccabe commented on PR #14934:
URL: https://github.com/apache/kafka/pull/14934#issuecomment-1845871637

   I guess this is reasonable. Thanks for the refactor, @soarez . +1. 
Committing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] MINOR: register before touch in BrokerHeartbeatManager [kafka]

[via GitHub]

soarez opened a new pull request, #14934:
URL: https://github.com/apache/kafka/pull/14934

   BrokerHeartbeatManager has a confusing API where it tolerates 
`touch(brokerId, fenced, metadataOffset)` without a previous call to 
`register(brokerId, fenced)`.
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org