Re: [PR] MINOR: remove test constructor for PartitionAssignment [kafka]
cmccabe merged PR #15435: URL: https://github.com/apache/kafka/pull/15435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINOR: remove test constructor for PartitionAssignment [kafka]
cmccabe commented on code in PR #15435:
URL: https://github.com/apache/kafka/pull/15435#discussion_r1513283747
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -792,6 +792,43 @@ class KRaftClusterTest {
}
}
+ /**
+ * Test that setting the Confluent-specific configuration
+ * confluent.apply.create.topic.policy.to.create.partitions has the expected
effect.
+ */
+ @ParameterizedTest
+ @ValueSource(strings = Array("3.7-IV0", "3.7-IV2"))
+ def testCreatePartitions(metadataVersionString: String): Unit = {
Review Comment:
This test passes before and after the change. I just added it because I
noticed a test gap in this area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MINOR: remove test constructor for PartitionAssignment [kafka]
chia7712 commented on code in PR #15435:
URL: https://github.com/apache/kafka/pull/15435#discussion_r1510329193
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -792,6 +792,43 @@ class KRaftClusterTest {
}
}
+ /**
+ * Test that setting the Confluent-specific configuration
+ * confluent.apply.create.topic.policy.to.create.partitions has the expected
effect.
+ */
+ @ParameterizedTest
+ @ValueSource(strings = Array("3.7-IV0", "3.7-IV2"))
+ def testCreatePartitions(metadataVersionString: String): Unit = {
Review Comment:
just curios. Is this test related to the constructor of PartitionAssignment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] MINOR: remove test constructor for PartitionAssignment [kafka]
cmccabe opened a new pull request, #15435: URL: https://github.com/apache/kafka/pull/15435 Remove the test constructor for PartitionAssignment and remove the TODO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
