Re: [PR] MINOR:Add hint for `resumeDeletions` in `TopicDeletionManager` [kafka]

2024-04-18 Thread via GitHub 


hudeqi commented on PR #15543:
URL: https://github.com/apache/kafka/pull/15543#issuecomment-2063665249

   Hi, @jlprat , could you help to review this pr?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] MINOR:Add hint for `resumeDeletions` in `TopicDeletionManager` [kafka]

2024-03-14 Thread via GitHub 


hudeqi opened a new pull request, #15543:
URL: https://github.com/apache/kafka/pull/15543

   The `resumeDeletions` method is called from multiple places and is the core 
logic responsible for executing the deletion. Therefore, adding comments to 
indicate where this method is being called can help better understand this part 
of the logic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org