Re: [PR] improve log description of QuorumController [kafka]
chickenchickenlove commented on PR #15926: URL: https://github.com/apache/kafka/pull/15926#issuecomment-2174863122 Hey, mumrah. Thanks for your time ♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improve log description of QuorumController [kafka]
mumrah merged PR #15926: URL: https://github.com/apache/kafka/pull/15926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improve log description of QuorumController [kafka]
mumrah commented on PR #15926: URL: https://github.com/apache/kafka/pull/15926#issuecomment-2173657505 Test failures look unrelated. Merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improve log description of QuorumController [kafka]
chickenchickenlove commented on PR #15926: URL: https://github.com/apache/kafka/pull/15926#issuecomment-2168090694 > I started a new build here https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15926/6/ Thanks for your comments. If there is something to be fixed, please let me know ♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improve log description of QuorumController [kafka]
mumrah commented on PR #15926: URL: https://github.com/apache/kafka/pull/15926#issuecomment-2166035023 I started a new build here https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15926/6/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improve log description of QuorumController [kafka]
chickenchickenlove commented on code in PR #15926:
URL: https://github.com/apache/kafka/pull/15926#discussion_r1632188911
##
metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java:
##
@@ -165,6 +165,8 @@ static ControllerResult recordsForNonEmptyLog(
throw new RuntimeException("Should not have ZK
migrations enabled on a cluster that was " +
"created in KRaft mode.");
}
+logMessageBuilder
+.append("This is expected because this is a
de-novo KRaft cluster.");
Review Comment:
@mumrah , i make new commit to apply your comments.
However, the `CI` still is failed.
The changes which i made seems not to be related with failure of CI.
Am i wrong?
https://github.com/apache/kafka/assets/90125071/d013add9-814d-4ad9-8c2e-cb2955455645;>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] improve log description of QuorumController [kafka]
mumrah commented on code in PR #15926:
URL: https://github.com/apache/kafka/pull/15926#discussion_r1631415177
##
metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java:
##
@@ -165,6 +165,8 @@ static ControllerResult recordsForNonEmptyLog(
throw new RuntimeException("Should not have ZK
migrations enabled on a cluster that was " +
"created in KRaft mode.");
}
+logMessageBuilder
+.append("This is expected because this is a
de-novo KRaft cluster.");
Review Comment:
nit: remove the unnecessary line break here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] improve log description of QuorumController [kafka]
chickenchickenlove commented on code in PR #15926:
URL: https://github.com/apache/kafka/pull/15926#discussion_r1629025724
##
metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java:
##
@@ -165,6 +165,8 @@ static ControllerResult recordsForNonEmptyLog(
throw new RuntimeException("Should not have ZK
migrations enabled on a cluster that was " +
"created in KRaft mode.");
}
+logMessageBuilder
+.append("since this is a de-novo KRaft cluster.");
Review Comment:
@mumrah gently ping.
When you have free time, please take another look?
Thanks in advance! ♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] improve log description of QuorumController [kafka]
chickenchickenlove commented on code in PR #15926:
URL: https://github.com/apache/kafka/pull/15926#discussion_r160061
##
metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java:
##
@@ -165,6 +165,8 @@ static ControllerResult recordsForNonEmptyLog(
throw new RuntimeException("Should not have ZK
migrations enabled on a cluster that was " +
"created in KRaft mode.");
}
+logMessageBuilder
+.append("since this is a de-novo KRaft cluster.");
Review Comment:
This is better
I make a new commit to apply your comments.
Please take another look, when you have free time ♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] improve log description of QuorumController [kafka]
mumrah commented on code in PR #15926:
URL: https://github.com/apache/kafka/pull/15926#discussion_r1600407308
##
metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java:
##
@@ -165,6 +165,8 @@ static ControllerResult recordsForNonEmptyLog(
throw new RuntimeException("Should not have ZK
migrations enabled on a cluster that was " +
"created in KRaft mode.");
}
+logMessageBuilder
+.append("since this is a de-novo KRaft cluster.");
Review Comment:
How about "This is expected because this is a de-novo KRaft cluster." ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] improve log description of QuorumController [kafka]
chickenchickenlove commented on PR #15926: URL: https://github.com/apache/kafka/pull/15926#issuecomment-2106104706 Hey, @mumrah ! I create PR to improve log desrcription when zookeeper.metadata.migration.enable is false. When you have free time, could you take a look? ♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improve log description of QuorumController [kafka]
chickenchickenlove closed pull request #15926: improve log description of QuorumController URL: https://github.com/apache/kafka/pull/15926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] improve log description of QuorumController [kafka]
chickenchickenlove commented on PR #15926: URL: https://github.com/apache/kafka/pull/15926#issuecomment-2106072426 Hey, @mumrah ! I made PR for https://issues.apache.org/jira/browse/KAFKA-16619! Could you please take a look, when you have free time? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
