[jira] [Comment Edited] (KAFKA-16123) KStreamKStreamJoinProcessor forwards null-key records for left/outer joins unconditionally of the join window.
[ https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814001#comment-17814001 ] Florin Akermann edited comment on KAFKA-16123 at 2/3/24 11:21 PM: -- This might actually be a general issue and not just for null-key records? In other words, the problem already existed prior to KIP-962 for non null-key records. See [https://github.com/apache/kafka/pull/15314/files] was (Author: aki): This might actually be a general issue and not just for null-key records? In other words, the problem already existed prior to KIP-962. See [https://github.com/apache/kafka/pull/15314/files] > KStreamKStreamJoinProcessor forwards null-key records for left/outer joins > unconditionally of the join window. > -- > > Key: KAFKA-16123 > URL: https://issues.apache.org/jira/browse/KAFKA-16123 > Project: Kafka > Issue Type: Bug > Components: streams >Reporter: Florin Akermann >Assignee: Florin Akermann >Priority: Major > > As part of KIP-962 the non-null key requirements have been relaxed for left > and outer joins. > However, the implementation forwards null-key records for left/outer joins > unconditionally of the join window. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (KAFKA-16123) KStreamKStreamJoinProcessor forwards null-key records for left/outer joins unconditionally of the join window.
[ https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814001#comment-17814001 ] Florin Akermann edited comment on KAFKA-16123 at 2/10/24 10:46 AM: --- This might actually be a general issue and not just for null-key records? In other words, the problem already existed prior to KIP-962 for non keyed records. See [https://github.com/apache/kafka/pull/15314/files] I'll generalize the PR to cover the key records as well. was (Author: aki): This might actually be a general issue and not just for null-key records? In other words, the problem already existed prior to KIP-962 for non null-key records. See [https://github.com/apache/kafka/pull/15314/files] I'll generalize the PR to cover the key records as well. > KStreamKStreamJoinProcessor forwards null-key records for left/outer joins > unconditionally of the join window. > -- > > Key: KAFKA-16123 > URL: https://issues.apache.org/jira/browse/KAFKA-16123 > Project: Kafka > Issue Type: Bug > Components: streams >Reporter: Florin Akermann >Assignee: Florin Akermann >Priority: Major > > As part of KIP-962 the non-null key requirements have been relaxed for left > and outer joins. > However, the implementation forwards null-key records for left/outer joins > unconditionally of the join window. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (KAFKA-16123) KStreamKStreamJoinProcessor forwards null-key records for left/outer joins unconditionally of the join window.
[ https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814001#comment-17814001 ] Florin Akermann edited comment on KAFKA-16123 at 2/10/24 10:45 AM: --- This might actually be a general issue and not just for null-key records? In other words, the problem already existed prior to KIP-962 for non null-key records. See [https://github.com/apache/kafka/pull/15314/files] I'll generalize the PR to cover the key records as well. was (Author: aki): This might actually be a general issue and not just for null-key records? In other words, the problem already existed prior to KIP-962 for non null-key records. See [https://github.com/apache/kafka/pull/15314/files] > KStreamKStreamJoinProcessor forwards null-key records for left/outer joins > unconditionally of the join window. > -- > > Key: KAFKA-16123 > URL: https://issues.apache.org/jira/browse/KAFKA-16123 > Project: Kafka > Issue Type: Bug > Components: streams >Reporter: Florin Akermann >Assignee: Florin Akermann >Priority: Major > > As part of KIP-962 the non-null key requirements have been relaxed for left > and outer joins. > However, the implementation forwards null-key records for left/outer joins > unconditionally of the join window. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (KAFKA-16123) KStreamKStreamJoinProcessor forwards null-key records for left/outer joins unconditionally of the join window.
[ https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814001#comment-17814001 ] Florin Akermann edited comment on KAFKA-16123 at 2/10/24 10:46 AM: --- This might actually be a general issue and not just for null-key records? In other words, the problem already existed prior to KIP-962 for keyed records. See [https://github.com/apache/kafka/pull/15314/files] I'll generalize the PR to cover the key records as well. was (Author: aki): This might actually be a general issue and not just for null-key records? In other words, the problem already existed prior to KIP-962 for non keyed records. See [https://github.com/apache/kafka/pull/15314/files] I'll generalize the PR to cover the key records as well. > KStreamKStreamJoinProcessor forwards null-key records for left/outer joins > unconditionally of the join window. > -- > > Key: KAFKA-16123 > URL: https://issues.apache.org/jira/browse/KAFKA-16123 > Project: Kafka > Issue Type: Bug > Components: streams >Reporter: Florin Akermann >Assignee: Florin Akermann >Priority: Major > > As part of KIP-962 the non-null key requirements have been relaxed for left > and outer joins. > However, the implementation forwards null-key records for left/outer joins > unconditionally of the join window. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (KAFKA-16123) KStreamKStreamJoinProcessor forwards null-key records for left/outer joins unconditionally of the join window.
[ https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816355#comment-17816355 ] Florin Akermann edited comment on KAFKA-16123 at 2/10/24 10:18 PM: --- I now committed a 'generalized fix' proposal was (Author: aki): I now committed a 'generalized fix' > KStreamKStreamJoinProcessor forwards null-key records for left/outer joins > unconditionally of the join window. > -- > > Key: KAFKA-16123 > URL: https://issues.apache.org/jira/browse/KAFKA-16123 > Project: Kafka > Issue Type: Bug > Components: streams >Reporter: Florin Akermann >Assignee: Florin Akermann >Priority: Major > > As part of KIP-962 the non-null key requirements have been relaxed for left > and outer joins. > However, the implementation forwards null-key records for left/outer joins > unconditionally of the join window. -- This message was sent by Atlassian Jira (v8.20.10#820010)
