[jira] [Commented] (KAFKA-12771) CheckStyle attempted upgrade (8.36.2 -->> 8.41.1) summons a pack of 'Indentation' errors
[ https://issues.apache.org/jira/browse/KAFKA-12771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345662#comment-17345662 ] Dejan Stojadinović commented on KAFKA-12771: Hello fellow-contributor [~dongjin] ! :D Yes, you are correct... I just linked related JIRA tickets and also I will link GitHub PR requests (on) > CheckStyle attempted upgrade (8.36.2 -->> 8.41.1) summons a pack of > 'Indentation' errors > > > Key: KAFKA-12771 > URL: https://issues.apache.org/jira/browse/KAFKA-12771 > Project: Kafka > Issue Type: Improvement > Components: build >Reporter: Dejan Stojadinović >Assignee: Dejan Stojadinović >Priority: Minor > > ^*Prologue*: > [https://github.com/apache/kafka/pull/10656#issuecomment-836071563]^ > *Scenario:* > * bump CheckStyle to a more recent version (8.36.2 -->> 8.41.1) > * introduce (temporarily !) maxErrors CheckStyle property (in order to count > errors) > * execute gradle command: *_./gradlew checkstyleMain checkstyleTest_* > * around 50 of 'Indentation' CheckStyle errors (across 18 source code files) > are shown > *Note:* there were some changes related to indentation between CheckStyle > *8.36.2* and *8.41.1*: > [https://checkstyle.sourceforge.io/releasenotes.html#Release_8.41.1] > *What can be done (options):* > # relax CheckStyle 'Indentation' rules (if possible) > # comply with new CheckStyle 'Indentation' rules (and change/fix indentation > fir these source code files) > # there are some slim chances that this is a some kind of CheckStyle > regression (maybe similar to this one: > [https://github.com/checkstyle/checkstyle/issues/9341]). This should be > checked with CheckStyle team. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-12771) CheckStyle attempted upgrade (8.36.2 -->> 8.41.1) summons a pack of 'Indentation' errors
[ https://issues.apache.org/jira/browse/KAFKA-12771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342288#comment-17342288 ] Dongjin Lee commented on KAFKA-12771: - Hi [~dejan2609], This issue is addressed in KAFKA-12572. Could you have [a look|https://github.com/apache/kafka/pull/10428]? It seems like we can upgrade checkstyle version after it is merged. > CheckStyle attempted upgrade (8.36.2 -->> 8.41.1) summons a pack of > 'Indentation' errors > > > Key: KAFKA-12771 > URL: https://issues.apache.org/jira/browse/KAFKA-12771 > Project: Kafka > Issue Type: Improvement > Components: build >Reporter: Dejan Stojadinović >Assignee: Dejan Stojadinović >Priority: Minor > > ^*Prologue*: > [https://github.com/apache/kafka/pull/10656#issuecomment-836071563]^ > *Scenario:* > * bump CheckStyle to a more recent version (8.36.2 -->> 8.41.1) > * introduce (temporarily !) maxErrors CheckStyle property (in order to count > errors) > * execute gradle command: *_./gradlew checkstyleMain checkstyleTest_* > * around 50 of 'Indentation' CheckStyle errors (across 18 source code files) > are shown > *Note:* there were some changes related to indentation between CheckStyle > *8.36.2* and *8.41.1*: > [https://checkstyle.sourceforge.io/releasenotes.html#Release_8.41.1] > *What can be done (options):* > # relax CheckStyle 'Indentation' rules (if possible) > # comply with new CheckStyle 'Indentation' rules (and change/fix indentation > fir these source code files) > # there are some slim chances that this is a some kind of CheckStyle > regression (maybe similar to this one: > [https://github.com/checkstyle/checkstyle/issues/9341]). This should be > checked with CheckStyle team. -- This message was sent by Atlassian Jira (v8.3.4#803005)
