[jira] [Commented] (KAFKA-12796) Removal of deprecated classes under `streams-scala`
[ https://issues.apache.org/jira/browse/KAFKA-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346301#comment-17346301 ] Josep Prat commented on KAFKA-12796: PR updated > Removal of deprecated classes under `streams-scala` > --- > > Key: KAFKA-12796 > URL: https://issues.apache.org/jira/browse/KAFKA-12796 > Project: Kafka > Issue Type: Task > Components: streams >Reporter: Josep Prat >Assignee: Josep Prat >Priority: Major > > There are 3 different classes that are deprecated under the streams-scala > submodule: > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Suppressed.scala > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/FunctionConversions.scala > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala > As far as I can tell, none of them are in use internally and could be removed > for release 3.0.0 > > Does this change require a KIP? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-12796) Removal of deprecated classes under `streams-scala`
[ https://issues.apache.org/jira/browse/KAFKA-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346297#comment-17346297 ] A. Sophie Blee-Goldman commented on KAFKA-12796: Awesome, thanks for picking this up. I'll leave [~cadonna] to be the main reviewer on this one when it's ready again > Removal of deprecated classes under `streams-scala` > --- > > Key: KAFKA-12796 > URL: https://issues.apache.org/jira/browse/KAFKA-12796 > Project: Kafka > Issue Type: Task > Components: streams >Reporter: Josep Prat >Assignee: Josep Prat >Priority: Major > > There are 3 different classes that are deprecated under the streams-scala > submodule: > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Suppressed.scala > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/FunctionConversions.scala > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala > As far as I can tell, none of them are in use internally and could be removed > for release 3.0.0 > > Does this change require a KIP? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-12796) Removal of deprecated classes under `streams-scala`
[
https://issues.apache.org/jira/browse/KAFKA-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346295#comment-17346295
]
Josep Prat commented on KAFKA-12796:
[~ableegoldman], then these are deletable:
*
streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Suppressed.scala
(@deprecated(message = "Use org.apache.kafka.streams.kstream.Suppressed",
since = "2.5"))
*
streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/FunctionConversions.scala
(@deprecated("This object is for internal use only", since = "2.1.0"))
Serdes was only deprecated since 2.7 (@deprecated("Use
org.apache.kafka.streams.scala.serialization.Serdes. For
WindowedSerdes.TimeWindowedSerde, use explicit constructors.", "2.7.0"))
I will update the PR restoring the Serdes class
> Removal of deprecated classes under `streams-scala`
> ---
>
> Key: KAFKA-12796
> URL: https://issues.apache.org/jira/browse/KAFKA-12796
> Project: Kafka
> Issue Type: Task
> Components: streams
>Reporter: Josep Prat
>Assignee: Josep Prat
>Priority: Major
>
> There are 3 different classes that are deprecated under the streams-scala
> submodule:
> *
> streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Suppressed.scala
> *
> streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/FunctionConversions.scala
> *
> streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala
> As far as I can tell, none of them are in use internally and could be removed
> for release 3.0.0
>
> Does this change require a KIP?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KAFKA-12796) Removal of deprecated classes under `streams-scala`
[ https://issues.apache.org/jira/browse/KAFKA-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346272#comment-17346272 ] A. Sophie Blee-Goldman commented on KAFKA-12796: [~josep.prat] can you track down when they were first deprecated? They should be deprecated since at least 2.5 for us to remove them in 3.0, otherwise it will need to wait until 4.0 If they haven't been deprecated for long enough yet, let's mark this ticket as a blocker for 4.0 instead > Removal of deprecated classes under `streams-scala` > --- > > Key: KAFKA-12796 > URL: https://issues.apache.org/jira/browse/KAFKA-12796 > Project: Kafka > Issue Type: Task > Components: streams >Reporter: Josep Prat >Assignee: Josep Prat >Priority: Major > > There are 3 different classes that are deprecated under the streams-scala > submodule: > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Suppressed.scala > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/FunctionConversions.scala > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala > As far as I can tell, none of them are in use internally and could be removed > for release 3.0.0 > > Does this change require a KIP? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-12796) Removal of deprecated classes under `streams-scala`
[ https://issues.apache.org/jira/browse/KAFKA-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346029#comment-17346029 ] Josep Prat commented on KAFKA-12796: I'll open a PR > Removal of deprecated classes under `streams-scala` > --- > > Key: KAFKA-12796 > URL: https://issues.apache.org/jira/browse/KAFKA-12796 > Project: Kafka > Issue Type: Task > Components: streams >Reporter: Josep Prat >Priority: Major > > There are 3 different classes that are deprecated under the streams-scala > submodule: > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Suppressed.scala > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/FunctionConversions.scala > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala > As far as I can tell, none of them are in use internally and could be removed > for release 3.0.0 > > Does this change require a KIP? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-12796) Removal of deprecated classes under `streams-scala`
[ https://issues.apache.org/jira/browse/KAFKA-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346023#comment-17346023 ] Bruno Cadonna commented on KAFKA-12796: --- Hi [~josep.prat], Thanks for the ticket! I do not think that we need a KIP for it since the deprecation itself was already accepted in a KIP. Please add a link to this ticket to KAFKA-12419 and see KAFKA-10434 for a similar ticket to this one. Feel free to open a PR to fix this. > Removal of deprecated classes under `streams-scala` > --- > > Key: KAFKA-12796 > URL: https://issues.apache.org/jira/browse/KAFKA-12796 > Project: Kafka > Issue Type: Task > Components: streams >Reporter: Josep Prat >Priority: Major > > There are 3 different classes that are deprecated under the streams-scala > submodule: > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Suppressed.scala > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/FunctionConversions.scala > * > streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala > As far as I can tell, none of them are in use internally and could be removed > for release 3.0.0 > > Does this change require a KIP? -- This message was sent by Atlassian Jira (v8.3.4#803005)
