[jira] [Commented] (KAFKA-13165) Validate node id, process role and quorum voters

2021-08-04 Thread Jose Armando Garcia Sancio (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-13165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393486#comment-17393486
 ] 

Jose Armando Garcia Sancio commented on KAFKA-13165:


We discussed this offline. We decided to have controller and brokers share the 
same id space. In other works it is expected that the id of a controller only 
node doesn't conflict with the id of a broker only node.

I am going to make the validation describe in this Jira a blocker of 3.0.

> Validate node id, process role and quorum voters
> 
>
> Key: KAFKA-13165
> URL: https://issues.apache.org/jira/browse/KAFKA-13165
> Project: Kafka
>  Issue Type: Sub-task
>  Components: kraft
>Reporter: Jose Armando Garcia Sancio
>Priority: Major
>
> Under certain configuration is possible for the Kafka Server to boot up as a 
> broker only but be the cluster metadata quorum leader. We should validate the 
> configuration to avoid this case.
>  # If the {{process.roles}} contains {{controller}} then the {{node.id}} 
> needs to be in the {{controller.quorum.voters}}
>  # If the {{process.roles}} doesn't contain {{controller}} then the 
> {{node.id}} cannot be in the {{controller.quorum.voters}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (KAFKA-13165) Validate node id, process role and quorum voters

2021-08-04 Thread Colin McCabe (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-13165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393313#comment-17393313
 ] 

Colin McCabe commented on KAFKA-13165:
--

The node ID space of controllers and brokers is disjoint. So we cannot find out 
anything useful by checking if the broker's node.id is in 
controller.quorum.voters.

Brokers should be observers in the raft quorum, so I don't see how the broker 
becoming a leader could be a problem. Maybe this is a loophole we need to 
close. We should be able to tell the RaftClient whether it is an observer or a 
voter.

> Validate node id, process role and quorum voters
> 
>
> Key: KAFKA-13165
> URL: https://issues.apache.org/jira/browse/KAFKA-13165
> Project: Kafka
>  Issue Type: Sub-task
>  Components: kraft
>Reporter: Jose Armando Garcia Sancio
>Priority: Major
>
> Under certain configuration is possible for the Kafka Server to boot up as a 
> broker only but be the cluster metadata quorum leader. We should validate the 
> configuration to avoid this case.
>  # If the {{process.roles}} contains {{controller}} then the {{node.id}} 
> needs to be in the {{controller.quorum.voters}}
>  # If the {{process.roles}} doesn't contain {{controller}} then the 
> {{node.id}} cannot be in the {{controller.quorum.voters}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)