[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538617#comment-17538617
]
François Rosière commented on KAFKA-13864:
--
This issue won't be implemented as KIP-832 will be replaced by KIP-839
achieving the same goal but in a better way.
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> The following changes should be applied in Kafka
> 1. Create 2 new constructors in _KafkaProducer_
> {code:java}
> public KafkaProducer(ProducerConfig config)
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer) {code}
> 2. Create a new constructor + increase the visibility of an existing
> constructor in _KafkaConsumer_
> {code:java}
> public KafkaConsumer(ConsumerConfig config)
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer){code}
> 3. Create 2 new constructors in _TopologyTestDriver_
> {code:java}
> public TopologyTestDriver(Topology topology, StreamsConfig config)
> public TopologyTestDriver(Topology topology, StreamsConfig config, Instant
> initialWallClockTime) {code}
> More details can be found in the related KIP
> [https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211882578]
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538542#comment-17538542
]
lqjacklee commented on KAFKA-13864:
---
[~frosiere] sorry late to reply , I have just resolved the VPN issue. I have
add the comment in the PR. please help review, thanks.
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> The following changes should be applied in Kafka
> 1. Create 2 new constructors in _KafkaProducer_
> {code:java}
> public KafkaProducer(ProducerConfig config)
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer) {code}
> 2. Create a new constructor + increase the visibility of an existing
> constructor in _KafkaConsumer_
> {code:java}
> public KafkaConsumer(ConsumerConfig config)
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer){code}
> 3. Create 2 new constructors in _TopologyTestDriver_
> {code:java}
> public TopologyTestDriver(Topology topology, StreamsConfig config)
> public TopologyTestDriver(Topology topology, StreamsConfig config, Instant
> initialWallClockTime) {code}
> More details can be found in the related KIP
> [https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211882578]
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17532518#comment-17532518
]
François Rosière commented on KAFKA-13864:
--
Thanks for the PR. I added some comments.
To progress on this issue, we still miss a vote or an approval to be able to
merge the issue once it will have been fully reviewed...
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> a new constructor should be added in KafkaProducer
> {code:java}
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer){code}
> the visibility of one constructor of KafkaConsumer should also move from
> default to public.
> {code:java}
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer) {code}
> see the current implementation
> https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671
> This issue is quite blocking , so, any other alternative or proposal would be
> more than welcome.
> Kafka streams is not concerned by this issue as the KafkaStreams object is
> already exposing a constructor taking a StreamsConfig object.
> Thanks for considering this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17532216#comment-17532216
]
lqjacklee commented on KAFKA-13864:
---
[~frosiere] [~cadonna] please help review the code , thanks .
https://github.com/apache/kafka/pull/12125/files
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> a new constructor should be added in KafkaProducer
> {code:java}
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer){code}
> the visibility of one constructor of KafkaConsumer should also move from
> default to public.
> {code:java}
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer) {code}
> see the current implementation
> https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671
> This issue is quite blocking , so, any other alternative or proposal would be
> more than welcome.
> Kafka streams is not concerned by this issue as the KafkaStreams object is
> already exposing a constructor taking a StreamsConfig object.
> Thanks for considering this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530937#comment-17530937
]
François Rosière commented on KAFKA-13864:
--
[~cadonna], table updated and discussion started.
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
> Attachments: interceptor_constructor_client.patch
>
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> a new constructor should be added in KafkaProducer
> {code:java}
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer){code}
> the visibility of one constructor of KafkaConsumer should also move from
> default to public.
> {code:java}
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer) {code}
> see the current implementation
> https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671
> This issue is quite blocking , so, any other alternative or proposal would be
> more than welcome.
> Kafka streams is not concerned by this issue as the KafkaStreams object is
> already exposing a constructor taking a StreamsConfig object.
> Thanks for considering this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530788#comment-17530788
]
Bruno Cadonna commented on KAFKA-13864:
---
[~frosiere] When you write a KIP you need to follow the process described in
the [KIP
doc|https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals]
under section "Process". Otherwise we will lose track of the KIP and nobody
will ever read your KIP and approve it. I incremented the "Next KIP Number" for
you. Now you need to add your KIP at the end of the table in section "KIPs
under discussion". Then you need to start a [DISCUSSION] thread on the dev
mailing list.
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
> Attachments: interceptor_constructor_client.patch
>
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> a new constructor should be added in KafkaProducer
> {code:java}
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer){code}
> the visibility of one constructor of KafkaConsumer should also move from
> default to public.
> {code:java}
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer) {code}
> see the current implementation
> https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671
> This issue is quite blocking , so, any other alternative or proposal would be
> more than welcome.
> Kafka streams is not concerned by this issue as the KafkaStreams object is
> already exposing a constructor taking a StreamsConfig object.
> Thanks for considering this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530722#comment-17530722
]
François Rosière commented on KAFKA-13864:
--
KIP-832 has been created.
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
> Attachments: interceptor_constructor_client.patch
>
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> a new constructor should be added in KafkaProducer
> {code:java}
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer){code}
> the visibility of one constructor of KafkaConsumer should also move from
> default to public.
> {code:java}
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer) {code}
> see the current implementation
> https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671
> This issue is quite blocking , so, any other alternative or proposal would be
> more than welcome.
> Kafka streams is not concerned by this issue as the KafkaStreams object is
> already exposing a constructor taking a StreamsConfig object.
> Thanks for considering this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530716#comment-17530716
]
Bruno Cadonna commented on KAFKA-13864:
---
[~frosiere] You should be all set now!
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
> Attachments: interceptor_constructor_client.patch
>
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> a new constructor should be added in KafkaProducer
> {code:java}
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer){code}
> the visibility of one constructor of KafkaConsumer should also move from
> default to public.
> {code:java}
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer) {code}
> see the current implementation
> https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671
> This issue is quite blocking , so, any other alternative or proposal would be
> more than welcome.
> Kafka streams is not concerned by this issue as the KafkaStreams object is
> already exposing a constructor taking a StreamsConfig object.
> Thanks for considering this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530707#comment-17530707
]
François Rosière commented on KAFKA-13864:
--
Make sense... frosiere is my account name on both Jira and Confluence. Thanks
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
> Attachments: interceptor_constructor_client.patch
>
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> a new constructor should be added in KafkaProducer
> {code:java}
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer){code}
> the visibility of one constructor of KafkaConsumer should also move from
> default to public.
> {code:java}
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer) {code}
> see the current implementation
> https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671
> This issue is quite blocking , so, any other alternative or proposal would be
> more than welcome.
> Kafka streams is not concerned by this issue as the KafkaStreams object is
> already exposing a constructor taking a StreamsConfig object.
> Thanks for considering this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530703#comment-17530703
]
Bruno Cadonna commented on KAFKA-13864:
---
Any change that impacts the public interface of a class for which the build
generates Javadocs are considered a major change and needs a KIP. The [KIP
doc|https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals]
is quite explicit about it.
Regarding the account: Let me know your account name and I can give you the
needed permissions.
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
> Attachments: interceptor_constructor_client.patch
>
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> a new constructor should be added in KafkaProducer
> {code:java}
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer){code}
> the visibility of one constructor of KafkaConsumer should also move from
> default to public.
> {code:java}
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer) {code}
> see the current implementation
> https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671
> This issue is quite blocking , so, any other alternative or proposal would be
> more than welcome.
> Kafka streams is not concerned by this issue as the KafkaStreams object is
> already exposing a constructor taking a StreamsConfig object.
> Thanks for considering this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530697#comment-17530697
]
François Rosière commented on KAFKA-13864:
--
KIP looks overkill in this specific case as we simply create a new constructor
+ increase the visibility of one existing constructor, no impact on existing
API and the usage is still the exact same. But let me create it...
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
> Attachments: interceptor_constructor_client.patch
>
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> a new constructor should be added in KafkaProducer
> {code:java}
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer){code}
> the visibility of one constructor of KafkaConsumer should also move from
> default to public.
> {code:java}
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer) {code}
> see the current implementation
> https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671
> This issue is quite blocking , so, any other alternative or proposal would be
> more than welcome.
> Kafka streams is not concerned by this issue as the KafkaStreams object is
> already exposing a constructor taking a StreamsConfig object.
> Thanks for considering this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530694#comment-17530694
]
Bruno Cadonna commented on KAFKA-13864:
---
[~Jack-Lee] Could you please open a GitHub PR against trunk? Reviewing a PR is
simpler than an attached patch. The title of the PR should start with
"KAFKA-13864:".
We still need a KIP before we can merge the PR.
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
> Attachments: interceptor_constructor_client.patch
>
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> a new constructor should be added in KafkaProducer
> {code:java}
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer){code}
> the visibility of one constructor of KafkaConsumer should also move from
> default to public.
> {code:java}
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer) {code}
> see the current implementation
> https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671
> This issue is quite blocking , so, any other alternative or proposal would be
> more than welcome.
> Kafka streams is not concerned by this issue as the KafkaStreams object is
> already exposing a constructor taking a StreamsConfig object.
> Thanks for considering this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530689#comment-17530689
]
lqjacklee commented on KAFKA-13864:
---
[~frosiere] [~cadonna] please help review the patch. Once we need the KIP ,
could I take the task?
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
> Attachments: interceptor_constructor_client.patch
>
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> a new constructor should be added in KafkaProducer
> {code:java}
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer){code}
> the visibility of one constructor of KafkaConsumer should also move from
> default to public.
> {code:java}
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer) {code}
> see the current implementation
> https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671
> This issue is quite blocking , so, any other alternative or proposal would be
> more than welcome.
> Kafka streams is not concerned by this issue as the KafkaStreams object is
> already exposing a constructor taking a StreamsConfig object.
> Thanks for considering this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530677#comment-17530677
]
Bruno Cadonna commented on KAFKA-13864:
---
[~frosiere][~Jack-Lee] I think this ticket needs a KIP since it plans to change
the public API.
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
> --
>
> Key: KAFKA-13864
> URL: https://issues.apache.org/jira/browse/KAFKA-13864
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 3.1.0
>Reporter: François Rosière
>Assignee: lqjacklee
>Priority: Major
> Labels: needs-kip
>
> To allow implementing Spring managed interceptors for producers and consumers,
> [https://github.com/spring-projects/spring-kafka/issues/2244]
> a new constructor should be added in KafkaProducer
> {code:java}
> public KafkaProducer(ProducerConfig config, Serializer keySerializer,
> Serializer valueSerializer){code}
> the visibility of one constructor of KafkaConsumer should also move from
> default to public.
> {code:java}
> public KafkaConsumer(ConsumerConfig config, Deserializer keyDeserializer,
> Deserializer valueDeserializer) {code}
> see the current implementation
> https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L671
> This issue is quite blocking , so, any other alternative or proposal would be
> more than welcome.
> Kafka streams is not concerned by this issue as the KafkaStreams object is
> already exposing a constructor taking a StreamsConfig object.
> Thanks for considering this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
