[jira] [Commented] (KAFKA-14241) Implement the snapshot cleanup policy

2023-04-17 Thread Mickael Maison (Jira) 


[ 
https://issues.apache.org/jira/browse/KAFKA-14241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712969#comment-17712969
 ] 

Mickael Maison commented on KAFKA-14241:


We're past feature freeze for 3.5.0 so moving to 3.6.0.

> Implement the snapshot cleanup policy
> -
>
> Key: KAFKA-14241
> URL: https://issues.apache.org/jira/browse/KAFKA-14241
> Project: Kafka
>  Issue Type: Sub-task
>  Components: kraft
>Reporter: Jose Armando Garcia Sancio
>Assignee: Jose Armando Garcia Sancio
>Priority: Major
> Fix For: 3.5.0
>
>
> It looks like delete policy needs to be set to either delete or compact:
> {code:java}
>         .define(CleanupPolicyProp, LIST, Defaults.CleanupPolicy, 
> ValidList.in(LogConfig.Compact, LogConfig.Delete), MEDIUM, CompactDoc,
>           KafkaConfig.LogCleanupPolicyProp)
> {code}
> Neither is correct for KRaft topics. KIP-630 talks about adding a third 
> policy called snapshot:
> {code:java}
> The __cluster_metadata topic will have snapshot as the cleanup.policy. {code}
> [https://cwiki.apache.org/confluence/display/KAFKA/KIP-630%3A+Kafka+Raft+Snapshot#KIP630:KafkaRaftSnapshot-ProposedChanges]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (KAFKA-14241) Implement the snapshot cleanup policy

2023-09-02 Thread Satish Duggana (Jira) 


[ 
https://issues.apache.org/jira/browse/KAFKA-14241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761535#comment-17761535
 ] 

Satish Duggana commented on KAFKA-14241:


Moving it to 3.7.0 as we are near code freeze and it is not a blocker.

> Implement the snapshot cleanup policy
> -
>
> Key: KAFKA-14241
> URL: https://issues.apache.org/jira/browse/KAFKA-14241
> Project: Kafka
>  Issue Type: Sub-task
>  Components: kraft
>Reporter: Jose Armando Garcia Sancio
>Assignee: Jose Armando Garcia Sancio
>Priority: Major
> Fix For: 3.6.0
>
>
> It looks like delete policy needs to be set to either delete or compact:
> {code:java}
>         .define(CleanupPolicyProp, LIST, Defaults.CleanupPolicy, 
> ValidList.in(LogConfig.Compact, LogConfig.Delete), MEDIUM, CompactDoc,
>           KafkaConfig.LogCleanupPolicyProp)
> {code}
> Neither is correct for KRaft topics. KIP-630 talks about adding a third 
> policy called snapshot:
> {code:java}
> The __cluster_metadata topic will have snapshot as the cleanup.policy. {code}
> [https://cwiki.apache.org/confluence/display/KAFKA/KIP-630%3A+Kafka+Raft+Snapshot#KIP630:KafkaRaftSnapshot-ProposedChanges]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (KAFKA-14241) Implement the snapshot cleanup policy

2022-12-14 Thread A. Sophie Blee-Goldman (Jira) 


[ 
https://issues.apache.org/jira/browse/KAFKA-14241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647819#comment-17647819
 ] 

A. Sophie Blee-Goldman commented on KAFKA-14241:


[~jagsancio]  bumping this to 3.5.0 as we are past code freeze for 3.4

> Implement the snapshot cleanup policy
> -
>
> Key: KAFKA-14241
> URL: https://issues.apache.org/jira/browse/KAFKA-14241
> Project: Kafka
>  Issue Type: Sub-task
>  Components: kraft
>Reporter: Jose Armando Garcia Sancio
>Assignee: Jose Armando Garcia Sancio
>Priority: Major
> Fix For: 3.4.0
>
>
> It looks like delete policy needs to be set to either delete or compact:
> {code:java}
>         .define(CleanupPolicyProp, LIST, Defaults.CleanupPolicy, 
> ValidList.in(LogConfig.Compact, LogConfig.Delete), MEDIUM, CompactDoc,
>           KafkaConfig.LogCleanupPolicyProp)
> {code}
> Neither is correct for KRaft topics. KIP-630 talks about adding a third 
> policy called snapshot:
> {code:java}
> The __cluster_metadata topic will have snapshot as the cleanup.policy. {code}
> [https://cwiki.apache.org/confluence/display/KAFKA/KIP-630%3A+Kafka+Raft+Snapshot#KIP630:KafkaRaftSnapshot-ProposedChanges]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (KAFKA-14241) Implement the snapshot cleanup policy

2022-09-18 Thread Ismael Juma (Jira) 


[ 
https://issues.apache.org/jira/browse/KAFKA-14241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606377#comment-17606377
 ] 

Ismael Juma commented on KAFKA-14241:
-

This should only be allowed for the cluster metadata kraft topic, right?

> Implement the snapshot cleanup policy
> -
>
> Key: KAFKA-14241
> URL: https://issues.apache.org/jira/browse/KAFKA-14241
> Project: Kafka
>  Issue Type: Sub-task
>  Components: kraft
>Reporter: Jose Armando Garcia Sancio
>Assignee: Jose Armando Garcia Sancio
>Priority: Major
> Fix For: 3.4.0
>
>
> It looks like delete policy needs to be set to either delete or compact:
> {code:java}
>         .define(CleanupPolicyProp, LIST, Defaults.CleanupPolicy, 
> ValidList.in(LogConfig.Compact, LogConfig.Delete), MEDIUM, CompactDoc,
>           KafkaConfig.LogCleanupPolicyProp)
> {code}
> Neither is correct for KRaft topics. KIP-630 talks about adding a third 
> policy called snapshot:
> {code:java}
> The __cluster_metadata topic will have snapshot as the cleanup.policy. {code}
> [https://cwiki.apache.org/confluence/display/KAFKA/KIP-630%3A+Kafka+Raft+Snapshot#KIP630:KafkaRaftSnapshot-ProposedChanges]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (KAFKA-14241) Implement the snapshot cleanup policy

2022-09-19 Thread Jose Armando Garcia Sancio (Jira) 


[ 
https://issues.apache.org/jira/browse/KAFKA-14241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606669#comment-17606669
 ] 

Jose Armando Garcia Sancio commented on KAFKA-14241:


Yes and those topics are internal at the moment. So at high-level we need to 
have a more complicated validation logic that is able to distinguish if the 
affected topic is a KRaft topic vs an ISR topic.

> Implement the snapshot cleanup policy
> -
>
> Key: KAFKA-14241
> URL: https://issues.apache.org/jira/browse/KAFKA-14241
> Project: Kafka
>  Issue Type: Sub-task
>  Components: kraft
>Reporter: Jose Armando Garcia Sancio
>Assignee: Jose Armando Garcia Sancio
>Priority: Major
> Fix For: 3.4.0
>
>
> It looks like delete policy needs to be set to either delete or compact:
> {code:java}
>         .define(CleanupPolicyProp, LIST, Defaults.CleanupPolicy, 
> ValidList.in(LogConfig.Compact, LogConfig.Delete), MEDIUM, CompactDoc,
>           KafkaConfig.LogCleanupPolicyProp)
> {code}
> Neither is correct for KRaft topics. KIP-630 talks about adding a third 
> policy called snapshot:
> {code:java}
> The __cluster_metadata topic will have snapshot as the cleanup.policy. {code}
> [https://cwiki.apache.org/confluence/display/KAFKA/KIP-630%3A+Kafka+Raft+Snapshot#KIP630:KafkaRaftSnapshot-ProposedChanges]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)