[jira] [Commented] (KAFKA-14579) Move DumpLogSegments to tools

2024-05-19 Thread Chia-Ping Tsai (Jira) 


[ 
https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847685#comment-17847685
 ] 

Chia-Ping Tsai commented on KAFKA-14579:


I create https://issues.apache.org/jira/browse/KAFKA-14579 to address that. It 
would be great to complete it before 3.8

> Move DumpLogSegments to tools
> -
>
> Key: KAFKA-14579
> URL: https://issues.apache.org/jira/browse/KAFKA-14579
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Mickael Maison
>Assignee: Alexandre Dupriez
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (KAFKA-14579) Move DumpLogSegments to tools

2024-05-04 Thread Chia-Ping Tsai (Jira) 


[ 
https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843422#comment-17843422
 ] 

Chia-Ping Tsai commented on KAFKA-14579:


{quote}
currently only DumpLogSegments is using Decoder, if it's removed then Decoder 
should be safe to be deprecated since no one will be using that anymore
{quote}

According to Kafka compatibility rule, command line tools belong to public 
interfaces. Hence, we need a replacement for `kafka.serializer.Decoder` and 
then deprecate `kafka.serializer.Decoder`. Also, the replacement should be 
written by Java and put into tools-api module.

> Move DumpLogSegments to tools
> -
>
> Key: KAFKA-14579
> URL: https://issues.apache.org/jira/browse/KAFKA-14579
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Mickael Maison
>Assignee: Alexandre Dupriez
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (KAFKA-14579) Move DumpLogSegments to tools

2024-05-04 Thread Johnny Hsu (Jira) 


[ 
https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843421#comment-17843421
 ] 

Johnny Hsu commented on KAFKA-14579:


currently only DumpLogSegments is using Decoder, if it's removed then Decoder 
should be safe to be deprecated since no one will be using that anymore 

> Move DumpLogSegments to tools
> -
>
> Key: KAFKA-14579
> URL: https://issues.apache.org/jira/browse/KAFKA-14579
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Mickael Maison
>Assignee: Alexandre Dupriez
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (KAFKA-14579) Move DumpLogSegments to tools

2024-05-03 Thread Chia-Ping Tsai (Jira) 


[ 
https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843219#comment-17843219
 ] 

Chia-Ping Tsai commented on KAFKA-14579:


After https://github.com/apache/kafka/pull/15652, `DumpLogSegments` only 
depends on `TransactionState`, `TransactionLogKey`, `TransactionLogValue`, and 
`Decoder`. They can be moved to  "transaction-coordinator" module. 
`TransactionState can be rewrite by java enum. Both `TransactionLogKey` and 
`TransactionLogValue` are generated code, so we need to enable 
"transaction-coordinator" to run generation. 

`Decoder` needs to be deprecated, so maybe we should file KIP for it first.





> Move DumpLogSegments to tools
> -
>
> Key: KAFKA-14579
> URL: https://issues.apache.org/jira/browse/KAFKA-14579
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Mickael Maison
>Assignee: Alexandre Dupriez
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (KAFKA-14579) Move DumpLogSegments to tools

2023-01-23 Thread Mickael Maison (Jira) 


[ 
https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679805#comment-17679805
 ] 

Mickael Maison commented on KAFKA-14579:


Since this depends on a bunch of log layer classes, it's best to wait till 
https://issues.apache.org/jira/browse/KAFKA-14470 is complete

> Move DumpLogSegments to tools
> -
>
> Key: KAFKA-14579
> URL: https://issues.apache.org/jira/browse/KAFKA-14579
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Mickael Maison
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (KAFKA-14579) Move DumpLogSegments to tools

2023-01-20 Thread Federico Valeri (Jira) 


[ 
https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679147#comment-17679147
 ] 

Federico Valeri commented on KAFKA-14579:
-

This tool has dependency on core module.

> Move DumpLogSegments to tools
> -
>
> Key: KAFKA-14579
> URL: https://issues.apache.org/jira/browse/KAFKA-14579
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Mickael Maison
>Assignee: Federico Valeri
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)