[jira] [Commented] (KAFKA-14586) Move StreamsResetter to tools
[ https://issues.apache.org/jira/browse/KAFKA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714140#comment-17714140 ] Sagar Rao commented on KAFKA-14586: --- Thanks [~fvaleri] , I created the PR. > Move StreamsResetter to tools > - > > Key: KAFKA-14586 > URL: https://issues.apache.org/jira/browse/KAFKA-14586 > Project: Kafka > Issue Type: Sub-task >Reporter: Mickael Maison >Assignee: Sagar Rao >Priority: Major > Fix For: 3.5.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-14586) Move StreamsResetter to tools
[ https://issues.apache.org/jira/browse/KAFKA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713966#comment-17713966 ] Federico Valeri commented on KAFKA-14586: - Thanks [~sagarrao]. When the redirection is merged, please also add it to the removal list for 4.0 release in KAFKA-14705. > Move StreamsResetter to tools > - > > Key: KAFKA-14586 > URL: https://issues.apache.org/jira/browse/KAFKA-14586 > Project: Kafka > Issue Type: Sub-task >Reporter: Mickael Maison >Assignee: Sagar Rao >Priority: Major > Fix For: 3.5.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-14586) Move StreamsResetter to tools
[ https://issues.apache.org/jira/browse/KAFKA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713911#comment-17713911 ] Sagar Rao commented on KAFKA-14586: --- [~mjsax] , I can add the redirection for this. I have read through KIP-906 so I can take [~fvaleri] 's help. Looks like the code freeze is next week, so i will try to accelerate on this. > Move StreamsResetter to tools > - > > Key: KAFKA-14586 > URL: https://issues.apache.org/jira/browse/KAFKA-14586 > Project: Kafka > Issue Type: Sub-task >Reporter: Mickael Maison >Assignee: Sagar Rao >Priority: Major > Fix For: 3.5.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-14586) Move StreamsResetter to tools
[ https://issues.apache.org/jira/browse/KAFKA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713836#comment-17713836 ] Matthias J. Sax commented on KAFKA-14586: - Thanks for providing context, and no worries about not knowing about the other KIP (there is too many things going on, and I also just realized the overlap). Yes, `StreamsResetter` might be used programmatically, so we should add a redirection. Who will do this? Guess we should get it in before code freeze to not delay the release. I am not worried about moving the test because it's not user facing. Overall, it seem we can close out the other KIP and ticket as "subsumed" by this ticket/KIP. I can do the cleanup for it. Just let me know if there is anything I can help with, or if the matter is resolved after we got the missing redirection merged. > Move StreamsResetter to tools > - > > Key: KAFKA-14586 > URL: https://issues.apache.org/jira/browse/KAFKA-14586 > Project: Kafka > Issue Type: Sub-task >Reporter: Mickael Maison >Assignee: Sagar Rao >Priority: Major > Fix For: 3.5.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-14586) Move StreamsResetter to tools
[ https://issues.apache.org/jira/browse/KAFKA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713490#comment-17713490 ] Mickael Maison commented on KAFKA-14586: [~mjsax] As Federico mentioned because StreamsResetter has a script, kafka-streams-application-reset.sh, we did not do a redirection. If you think that may break some users, we can add it. > Move StreamsResetter to tools > - > > Key: KAFKA-14586 > URL: https://issues.apache.org/jira/browse/KAFKA-14586 > Project: Kafka > Issue Type: Sub-task >Reporter: Mickael Maison >Assignee: Sagar Rao >Priority: Major > Fix For: 3.5.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-14586) Move StreamsResetter to tools
[ https://issues.apache.org/jira/browse/KAFKA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713484#comment-17713484 ] Federico Valeri commented on KAFKA-14586: - [~mjsax] Thanks for raising this. According to KIP-906, only tools with missing wrapper scripts need to have a redirection object inside core (to be removed in 4.0), to avoid breaking user scripts using kafka-run-class.sh along with the tool's FQCN. The StreamsResetter already had wrapper scripts, so users are supposed to use them, and we are free to change the package without redirection in this case (we only add a migration note to docs/upgrade.html). In the end, I think we can close the Issue and discard the KIP you are referring to. I would also like to point out that the migration is not complete, because there is still the StreamResetterTest to move, and this is being tracked in KAFKA-14851. > Move StreamsResetter to tools > - > > Key: KAFKA-14586 > URL: https://issues.apache.org/jira/browse/KAFKA-14586 > Project: Kafka > Issue Type: Sub-task >Reporter: Mickael Maison >Assignee: Sagar Rao >Priority: Major > Fix For: 3.5.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-14586) Move StreamsResetter to tools
[ https://issues.apache.org/jira/browse/KAFKA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713388#comment-17713388 ] Sagar Rao commented on KAFKA-14586: --- [~mjsax] , oh I didn't know there was already a KIP and a Jira filed for this. I think we should be able to close the older ones. cc [~fvaleri] > Move StreamsResetter to tools > - > > Key: KAFKA-14586 > URL: https://issues.apache.org/jira/browse/KAFKA-14586 > Project: Kafka > Issue Type: Sub-task >Reporter: Mickael Maison >Assignee: Sagar Rao >Priority: Major > Fix For: 3.5.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-14586) Move StreamsResetter to tools
[ https://issues.apache.org/jira/browse/KAFKA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713233#comment-17713233 ] Matthias J. Sax commented on KAFKA-14586: - [~mimaison] [~sagarrao] – I am just realizing that we did this as part of 3.5 – We actually had https://issues.apache.org/jira/browse/KAFKA-4327 that we did not do in the past, because we thought we should only do it in major release, as it seems to be a breaking change (we also had [https://cwiki.apache.org/confluence/display/KAFKA/KIP-756%3A+Move+StreamsResetter+tool+outside+of+core] for it) Seems you solve the issue about introducing a breaking change with some "redirection" according to KIP-906. So we can we close K4327 and the K-756? > Move StreamsResetter to tools > - > > Key: KAFKA-14586 > URL: https://issues.apache.org/jira/browse/KAFKA-14586 > Project: Kafka > Issue Type: Sub-task >Reporter: Mickael Maison >Assignee: Sagar Rao >Priority: Major > Fix For: 3.5.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
