[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796383#comment-17796383 ] Federico Valeri commented on KAFKA-15853: - [~ijuma] the current StrageTool implementation implicitly calls validateValues() when instantiating KafkaConfig. https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaConfig.scala#L2266 I'm not completely sure that the full validation was intentional, but not having this in Java would be a behavior change. Wdyt? > Move KafkaConfig to server module > - > > Key: KAFKA-15853 > URL: https://issues.apache.org/jira/browse/KAFKA-15853 > Project: Kafka > Issue Type: Sub-task >Reporter: Ismael Juma >Assignee: Omnia Ibrahim >Priority: Major > > The server module is a Java-only module, so this also requires converting > from Scala to Java. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795820#comment-17795820 ] Omnia Ibrahim commented on KAFKA-15853: --- Another thing we depend on here is `KafkaZkClient`(needed for DynamicBrokerConfig), `Broker`, `LogManager`, etc. I think we also need to have intrafaces that cover these as well so we avoid depending on core from server. My only concerns here is that any thing involved because of `kafka.zk` will be dropped anyway in 4.0 so not sure how much effort should be put into these. [~ijuma] any thoughts? > Move KafkaConfig to server module > - > > Key: KAFKA-15853 > URL: https://issues.apache.org/jira/browse/KAFKA-15853 > Project: Kafka > Issue Type: Sub-task >Reporter: Ismael Juma >Assignee: Omnia Ibrahim >Priority: Major > > The server module is a Java-only module, so this also requires converting > from Scala to Java. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794187#comment-17794187 ] Ismael Juma commented on KAFKA-15853: - [~fvaleri] Why does your work depend on this? Ideally, tools and other modules should not require `KafkaConfig`. They should instead specify interfaces that cover their needs. This is the same we did for the `storage` module. > Move KafkaConfig to server module > - > > Key: KAFKA-15853 > URL: https://issues.apache.org/jira/browse/KAFKA-15853 > Project: Kafka > Issue Type: Sub-task >Reporter: Ismael Juma >Assignee: Omnia Ibrahim >Priority: Major > > The server module is a Java-only module, so this also requires converting > from Scala to Java. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794185#comment-17794185 ] Federico Valeri commented on KAFKA-15853: - Didn't mean to put pressure on you, just wanted to check the current status. Let me know if I can help in any way. Many thanks. > Move KafkaConfig to server module > - > > Key: KAFKA-15853 > URL: https://issues.apache.org/jira/browse/KAFKA-15853 > Project: Kafka > Issue Type: Sub-task >Reporter: Ismael Juma >Assignee: Omnia Ibrahim >Priority: Major > > The server module is a Java-only module, so this also requires converting > from Scala to Java. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793645#comment-17793645 ] Omnia Ibrahim commented on KAFKA-15853: --- [~fvaleri] Am still working on it it's nearly there (maybe in a week/week and half). It's just not small work as KafkaConfig depends on too many other classes that need to be moved as well at the same time. Will have a look into your PR and let you know when KafkaConfig pr is ready for review. > Move KafkaConfig to server module > - > > Key: KAFKA-15853 > URL: https://issues.apache.org/jira/browse/KAFKA-15853 > Project: Kafka > Issue Type: Sub-task >Reporter: Ismael Juma >Assignee: Omnia Ibrahim >Priority: Major > > The server module is a Java-only module, so this also requires converting > from Scala to Java. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793602#comment-17793602 ] Federico Valeri commented on KAFKA-15853: - [~omnia_h_ibrahim] I have a tools PR that may depend on this one, specifically on KafkaConfig.validateValues. Are you still working on migrating KafkaConfig? Let me know if I can help with the review. https://github.com/apache/kafka/pull/14847 > Move KafkaConfig to server module > - > > Key: KAFKA-15853 > URL: https://issues.apache.org/jira/browse/KAFKA-15853 > Project: Kafka > Issue Type: Sub-task >Reporter: Ismael Juma >Assignee: Omnia Ibrahim >Priority: Major > > The server module is a Java-only module, so this also requires converting > from Scala to Java. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789707#comment-17789707 ] Ismael Juma commented on KAFKA-15853: - [~omnia_h_ibrahim] Sounds reasonable to me. The `ProcessRole` items should go to the server module, yes. > Move KafkaConfig to server module > - > > Key: KAFKA-15853 > URL: https://issues.apache.org/jira/browse/KAFKA-15853 > Project: Kafka > Issue Type: Sub-task >Reporter: Ismael Juma >Assignee: Omnia Ibrahim >Priority: Major > > The server module is a Java-only module, so this also requires converting > from Scala to Java. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module
[
https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789703#comment-17789703
]
Omnia Ibrahim commented on KAFKA-15853:
---
As KafkaConfig depends on many object compinanion of other Configs, Managers or
other classes am thinking of moving only the object compinon of these at least
to
- OffsetConfig will move to group-coordinator
- TransactionLog and TransactionStateManager to group-coordinator under
transaction package
- DynamicBrokerConfig to server -> Need Jira ticket (am mostly done with this
work)
- ReplicationQuotaManagerConfig to server -> Currently I will move it out of
ReplicationQuotaManager.scala to its own class in server module
- ClientQuotaManagerConfig to Server -> Same as ReplicationQuotaManagerConfig
will move it out of ClientQuotaManager.scala to its own class in server
- kafka.server.KafkaRaftServer.\{BrokerRole, ControllerRole, ProcessRole} ->
Move these objects of ProcessRole to server module or raft module (I think
server is more fit).
[~ijuma] thoughts?
> Move KafkaConfig to server module
> -
>
> Key: KAFKA-15853
> URL: https://issues.apache.org/jira/browse/KAFKA-15853
> Project: Kafka
> Issue Type: Sub-task
>Reporter: Ismael Juma
>Assignee: Omnia Ibrahim
>Priority: Major
>
> The server module is a Java-only module, so this also requires converting
> from Scala to Java.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787998#comment-17787998 ] Omnia Ibrahim commented on KAFKA-15853: --- I assigned it to myself. One note; `KafkaConfig` depends on default values of other configs like `OffsetConfig` and `TransactionLog`. I'll move the defaults for these configs out of the core and into `group-coordinator` for now as I can't see any work scheduled/planned for moving `transaction` out of the core so not sure if `group-coordinator` is the right place for these or not. If not maybe we need to move all default config values to an extra new module or to `server-common`. WDYT? > Move KafkaConfig to server module > - > > Key: KAFKA-15853 > URL: https://issues.apache.org/jira/browse/KAFKA-15853 > Project: Kafka > Issue Type: Sub-task >Reporter: Ismael Juma >Assignee: Omnia Ibrahim >Priority: Major > > The server module is a Java-only module, so this also requires converting > from Scala to Java. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787674#comment-17787674 ] Ismael Juma commented on KAFKA-15853: - Feel free to take this. KAFKA-15854 is a dependency and will be merged soon. > Move KafkaConfig to server module > - > > Key: KAFKA-15853 > URL: https://issues.apache.org/jira/browse/KAFKA-15853 > Project: Kafka > Issue Type: Sub-task >Reporter: Ismael Juma >Priority: Major > > The server module is a Java-only module, so this also requires converting > from Scala to Java. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787672#comment-17787672 ] Omnia Ibrahim commented on KAFKA-15853: --- [~ijuma] any plans when will this be landing as KAFKA-14527 depends on it? if you are busy am happy to take this ticket. > Move KafkaConfig to server module > - > > Key: KAFKA-15853 > URL: https://issues.apache.org/jira/browse/KAFKA-15853 > Project: Kafka > Issue Type: Sub-task >Reporter: Ismael Juma >Priority: Major > > The server module is a Java-only module, so this also requires converting > from Scala to Java. -- This message was sent by Atlassian Jira (v8.20.10#820010)
