[jira] [Commented] (KAFKA-16830) Remove the scala version formatters support

2024-06-21 Thread Kuan Po Tseng (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-16830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17856809#comment-17856809
 ] 

Kuan Po Tseng commented on KAFKA-16830:
---

Hi [~ksolves.kafka] , yes, I'm working on this one.

> Remove the scala version formatters support
> ---
>
> Key: KAFKA-16830
> URL: https://issues.apache.org/jira/browse/KAFKA-16830
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Ksolves
>Priority: Minor
> Fix For: 4.0.0
>
>
> https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java#L353
>  
> {code:java}
> private static String convertDeprecatedClass(String className) {
> switch (className) {
> case "kafka.tools.DefaultMessageFormatter":
> System.err.println("WARNING: 
> kafka.tools.DefaultMessageFormatter is deprecated and will be removed in the 
> next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.DefaultMessageFormatter instead");
> return DefaultMessageFormatter.class.getName();
> case "kafka.tools.LoggingMessageFormatter":
> System.err.println("WARNING: 
> kafka.tools.LoggingMessageFormatter is deprecated and will be removed in the 
> next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.LoggingMessageFormatter instead");
> return LoggingMessageFormatter.class.getName();
> case "kafka.tools.NoOpMessageFormatter":
> System.err.println("WARNING: kafka.tools.NoOpMessageFormatter 
> is deprecated and will be removed in the next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.NoOpMessageFormatter instead");
> return NoOpMessageFormatter.class.getName();
> default:
> return className;
> }
> }
> {code}
> Those deprecated formatters "strings" should be removed from 4.0.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KAFKA-16830) Remove the scala version formatters support

2024-06-21 Thread Chia-Ping Tsai (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-16830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17856748#comment-17856748
 ] 

Chia-Ping Tsai commented on KAFKA-16830:


[~ksolves.kafka]  this issue should be shipped to 4.0, so all we can do is to 
wait :)

> Remove the scala version formatters support
> ---
>
> Key: KAFKA-16830
> URL: https://issues.apache.org/jira/browse/KAFKA-16830
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Ksolves
>Priority: Minor
> Fix For: 4.0.0
>
>
> https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java#L353
>  
> {code:java}
> private static String convertDeprecatedClass(String className) {
> switch (className) {
> case "kafka.tools.DefaultMessageFormatter":
> System.err.println("WARNING: 
> kafka.tools.DefaultMessageFormatter is deprecated and will be removed in the 
> next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.DefaultMessageFormatter instead");
> return DefaultMessageFormatter.class.getName();
> case "kafka.tools.LoggingMessageFormatter":
> System.err.println("WARNING: 
> kafka.tools.LoggingMessageFormatter is deprecated and will be removed in the 
> next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.LoggingMessageFormatter instead");
> return LoggingMessageFormatter.class.getName();
> case "kafka.tools.NoOpMessageFormatter":
> System.err.println("WARNING: kafka.tools.NoOpMessageFormatter 
> is deprecated and will be removed in the next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.NoOpMessageFormatter instead");
> return NoOpMessageFormatter.class.getName();
> default:
> return className;
> }
> }
> {code}
> Those deprecated formatters "strings" should be removed from 4.0.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KAFKA-16830) Remove the scala version formatters support

2024-06-21 Thread Ksolves (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-16830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17856737#comment-17856737
 ] 

Ksolves commented on KAFKA-16830:
-

[~brandboat] I didn't check that it was assigned to you. Also, I have assigned 
this to myself. Let me know if you're working on this.

> Remove the scala version formatters support
> ---
>
> Key: KAFKA-16830
> URL: https://issues.apache.org/jira/browse/KAFKA-16830
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Ksolves
>Priority: Minor
> Fix For: 4.0.0
>
>
> https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java#L353
>  
> {code:java}
> private static String convertDeprecatedClass(String className) {
> switch (className) {
> case "kafka.tools.DefaultMessageFormatter":
> System.err.println("WARNING: 
> kafka.tools.DefaultMessageFormatter is deprecated and will be removed in the 
> next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.DefaultMessageFormatter instead");
> return DefaultMessageFormatter.class.getName();
> case "kafka.tools.LoggingMessageFormatter":
> System.err.println("WARNING: 
> kafka.tools.LoggingMessageFormatter is deprecated and will be removed in the 
> next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.LoggingMessageFormatter instead");
> return LoggingMessageFormatter.class.getName();
> case "kafka.tools.NoOpMessageFormatter":
> System.err.println("WARNING: kafka.tools.NoOpMessageFormatter 
> is deprecated and will be removed in the next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.NoOpMessageFormatter instead");
> return NoOpMessageFormatter.class.getName();
> default:
> return className;
> }
> }
> {code}
> Those deprecated formatters "strings" should be removed from 4.0.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KAFKA-16830) Remove the scala version formatters support

2024-06-21 Thread Ksolves (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-16830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17856736#comment-17856736
 ] 

Ksolves commented on KAFKA-16830:
-

Thanks [~chia7712] and [~brandboat] 

Will review and start working on this.

> Remove the scala version formatters support
> ---
>
> Key: KAFKA-16830
> URL: https://issues.apache.org/jira/browse/KAFKA-16830
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Kuan Po Tseng
>Priority: Minor
> Fix For: 4.0.0
>
>
> https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java#L353
>  
> {code:java}
> private static String convertDeprecatedClass(String className) {
> switch (className) {
> case "kafka.tools.DefaultMessageFormatter":
> System.err.println("WARNING: 
> kafka.tools.DefaultMessageFormatter is deprecated and will be removed in the 
> next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.DefaultMessageFormatter instead");
> return DefaultMessageFormatter.class.getName();
> case "kafka.tools.LoggingMessageFormatter":
> System.err.println("WARNING: 
> kafka.tools.LoggingMessageFormatter is deprecated and will be removed in the 
> next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.LoggingMessageFormatter instead");
> return LoggingMessageFormatter.class.getName();
> case "kafka.tools.NoOpMessageFormatter":
> System.err.println("WARNING: kafka.tools.NoOpMessageFormatter 
> is deprecated and will be removed in the next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.NoOpMessageFormatter instead");
> return NoOpMessageFormatter.class.getName();
> default:
> return className;
> }
> }
> {code}
> Those deprecated formatters "strings" should be removed from 4.0.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KAFKA-16830) Remove the scala version formatters support

2024-06-21 Thread Kuan Po Tseng (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-16830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17856734#comment-17856734
 ] 

Kuan Po Tseng commented on KAFKA-16830:
---

hi [~ksolves.kafka] , this Jira is a follow up of 
https://issues.apache.org/jira/browse/KAFKA-16795, and we are going to remove 
[https://github.com/apache/kafka/blob/9b5b434e2a6b2d5290ea403fc02859b1c523d8aa/tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java#L353]
this line in 4.0.0

> Remove the scala version formatters support
> ---
>
> Key: KAFKA-16830
> URL: https://issues.apache.org/jira/browse/KAFKA-16830
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Kuan Po Tseng
>Priority: Minor
> Fix For: 4.0.0
>
>
> https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java#L353
>  
> {code:java}
> private static String convertDeprecatedClass(String className) {
> switch (className) {
> case "kafka.tools.DefaultMessageFormatter":
> System.err.println("WARNING: 
> kafka.tools.DefaultMessageFormatter is deprecated and will be removed in the 
> next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.DefaultMessageFormatter instead");
> return DefaultMessageFormatter.class.getName();
> case "kafka.tools.LoggingMessageFormatter":
> System.err.println("WARNING: 
> kafka.tools.LoggingMessageFormatter is deprecated and will be removed in the 
> next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.LoggingMessageFormatter instead");
> return LoggingMessageFormatter.class.getName();
> case "kafka.tools.NoOpMessageFormatter":
> System.err.println("WARNING: kafka.tools.NoOpMessageFormatter 
> is deprecated and will be removed in the next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.NoOpMessageFormatter instead");
> return NoOpMessageFormatter.class.getName();
> default:
> return className;
> }
> }
> {code}
> Those deprecated formatters "strings" should be removed from 4.0.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KAFKA-16830) Remove the scala version formatters support

2024-06-21 Thread Chia-Ping Tsai (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-16830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17856732#comment-17856732
 ] 

Chia-Ping Tsai commented on KAFKA-16830:


{quote}
Can you update the GitHub link, please?
{quote}
done!

> Remove the scala version formatters support
> ---
>
> Key: KAFKA-16830
> URL: https://issues.apache.org/jira/browse/KAFKA-16830
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Kuan Po Tseng
>Priority: Minor
> Fix For: 4.0.0
>
>
> https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java#L353
>  
> {code:java}
> private static String convertDeprecatedClass(String className) {
> switch (className) {
> case "kafka.tools.DefaultMessageFormatter":
> System.err.println("WARNING: 
> kafka.tools.DefaultMessageFormatter is deprecated and will be removed in the 
> next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.DefaultMessageFormatter instead");
> return DefaultMessageFormatter.class.getName();
> case "kafka.tools.LoggingMessageFormatter":
> System.err.println("WARNING: 
> kafka.tools.LoggingMessageFormatter is deprecated and will be removed in the 
> next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.LoggingMessageFormatter instead");
> return LoggingMessageFormatter.class.getName();
> case "kafka.tools.NoOpMessageFormatter":
> System.err.println("WARNING: kafka.tools.NoOpMessageFormatter 
> is deprecated and will be removed in the next major release. " +
> "Please use 
> org.apache.kafka.tools.consumer.NoOpMessageFormatter instead");
> return NoOpMessageFormatter.class.getName();
> default:
> return className;
> }
> }
> {code}
> Those deprecated formatters "strings" should be removed from 4.0.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (KAFKA-16830) Remove the scala version formatters support

2024-06-21 Thread Ksolves (Jira)


[ 
https://issues.apache.org/jira/browse/KAFKA-16830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17856730#comment-17856730
 ] 

Ksolves commented on KAFKA-16830:
-

[~chia7712] Seems like the class is updated as L72 is showing a blank line. Can 
you update the GitHub link, please?

> Remove the scala version formatters support
> ---
>
> Key: KAFKA-16830
> URL: https://issues.apache.org/jira/browse/KAFKA-16830
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Chia-Ping Tsai
>Assignee: Kuan Po Tseng
>Priority: Minor
> Fix For: 4.0.0
>
>
> [https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java#L72]
>  
> Those deprecated formatters "strings" should be removed from 4.0.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)