[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[
https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108462#comment-16108462
]
Pranav Maniar commented on KAFKA-1944:
--
It seems that there are agreement/disagreement related to change...
So should I create KIP or first we discuss it over JIRA/mailing list ?
Also, what about other cleaner configs apart from {{log.cleaner.enable}} ? Does
any of the other cleaner config also requires renaming ? E.g.
> Rename LogCleaner and related classes to LogCompactor
> -
>
> Key: KAFKA-1944
> URL: https://issues.apache.org/jira/browse/KAFKA-1944
> Project: Kafka
> Issue Type: Bug
>Reporter: Gwen Shapira
>Assignee: Pranav Maniar
> Labels: newbie
>
> Following a mailing list discussion:
> "the name LogCleaner is seriously misleading. Its more of a log compactor.
> Deleting old logs happens elsewhere from what I've seen."
> Note that this may require renaming related classes, objects, configs and
> metrics.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107678#comment-16107678 ] Ismael Juma commented on KAFKA-1944: By the way, we should also consider whether this change is worth it. After all, many are used to the existing names. Is the improvement worth the disruption? > Rename LogCleaner and related classes to LogCompactor > - > > Key: KAFKA-1944 > URL: https://issues.apache.org/jira/browse/KAFKA-1944 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Aravind Selvan > Labels: newbie > > Following a mailing list discussion: > "the name LogCleaner is seriously misleading. Its more of a log compactor. > Deleting old logs happens elsewhere from what I've seen." > Note that this may require renaming related classes, objects, configs and > metrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107346#comment-16107346 ] Pranav Maniar commented on KAFKA-1944: -- Thanks [~becket_qin] , I will go through wiki page and try to create KIP. I see that I can't access KIP-template. If you can assign permission it will be great. Meanwhile I will also send mail to d...@kafka.apache.org as mentioned on wiki page. > Rename LogCleaner and related classes to LogCompactor > - > > Key: KAFKA-1944 > URL: https://issues.apache.org/jira/browse/KAFKA-1944 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Aravind Selvan > Labels: newbie > > Following a mailing list discussion: > "the name LogCleaner is seriously misleading. Its more of a log compactor. > Deleting old logs happens elsewhere from what I've seen." > Note that this may require renaming related classes, objects, configs and > metrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[
https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105959#comment-16105959
]
Jiangjie Qin commented on KAFKA-1944:
-
I agree with [~hachikuji] that we can deprecate {{log.cleaner.enable}}. The
name "log.cleaner" appears in a handful of other configurations related to log
cleaner. We will need to change those following the deprecation process as
well. It would likely be a quick KIP.
> Rename LogCleaner and related classes to LogCompactor
> -
>
> Key: KAFKA-1944
> URL: https://issues.apache.org/jira/browse/KAFKA-1944
> Project: Kafka
> Issue Type: Bug
>Reporter: Gwen Shapira
>Assignee: Aravind Selvan
> Labels: newbie
>
> Following a mailing list discussion:
> "the name LogCleaner is seriously misleading. Its more of a log compactor.
> Deleting old logs happens elsewhere from what I've seen."
> Note that this may require renaming related classes, objects, configs and
> metrics.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[
https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105845#comment-16105845
]
Jason Gustafson commented on KAFKA-1944:
The name LogCleaner is somewhat entrenched. If this is just a matter of
renaming {{LogCleaner}} to {{LogCompactor}}, that could be done in a MINOR PR,
but that probably only makes sense if we change the configuration
{{log.cleaner.enable}} as well. On the other hand, since we have changed its
default value to true and since two key components now depend on it (i.e. the
new consumer and the transactional producer), maybe we should consider
deprecating the config instead?
> Rename LogCleaner and related classes to LogCompactor
> -
>
> Key: KAFKA-1944
> URL: https://issues.apache.org/jira/browse/KAFKA-1944
> Project: Kafka
> Issue Type: Bug
>Reporter: Gwen Shapira
>Assignee: Aravind Selvan
> Labels: newbie
>
> Following a mailing list discussion:
> "the name LogCleaner is seriously misleading. Its more of a log compactor.
> Deleting old logs happens elsewhere from what I've seen."
> Note that this may require renaming related classes, objects, configs and
> metrics.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor
[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103571#comment-16103571 ] Pranav Maniar commented on KAFKA-1944: -- Is someone working on this?? If not I can take it up. I am new to kafka and this seems like a refactoring task, which will be easy to start with.. P.S. : This issue seems to be old, so this still needs to be refactored ?? > Rename LogCleaner and related classes to LogCompactor > - > > Key: KAFKA-1944 > URL: https://issues.apache.org/jira/browse/KAFKA-1944 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Aravind Selvan > Labels: newbie > > Following a mailing list discussion: > "the name LogCleaner is seriously misleading. Its more of a log compactor. > Deleting old logs happens elsewhere from what I've seen." > Note that this may require renaming related classes, objects, configs and > metrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
