[jira] [Commented] (KAFKA-2423) Introduce Scalastyle
[ https://issues.apache.org/jira/browse/KAFKA-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356374#comment-16356374 ] Ray Chiang commented on KAFKA-2423: --- Hmmm...it looks like my PR has a different default text. Please let me know how to adjust this for the next time. Some quick notes on the PR: * Kept Grant's earlier Gradle file setup * Updated plugin to version 0.9.0 * Removed some calls from the previous PR since that's now in the main build.gradle * Put the output into core/build/scalastyle/scalastyle_report.xml and set quiet = true. Keeps the terminal output to a minimum * Set failOnViolation = false to keep Scalastyle warnings from being flagged as an error by Gradle. > Introduce Scalastyle > > > Key: KAFKA-2423 > URL: https://issues.apache.org/jira/browse/KAFKA-2423 > Project: Kafka > Issue Type: Improvement >Reporter: Ismael Juma >Assignee: Ray Chiang >Priority: Major > > This is similar to Checkstyle (which we already use), but for Scala: > http://www.scalastyle.org/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KAFKA-2423) Introduce Scalastyle
[ https://issues.apache.org/jira/browse/KAFKA-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356371#comment-16356371 ] ASF GitHub Bot commented on KAFKA-2423: --- TolerableCoder opened a new pull request #4545: KAFKA-2423: Introduce Scalastyle URL: https://github.com/apache/kafka/pull/4545 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Introduce Scalastyle > > > Key: KAFKA-2423 > URL: https://issues.apache.org/jira/browse/KAFKA-2423 > Project: Kafka > Issue Type: Improvement >Reporter: Ismael Juma >Assignee: Ray Chiang >Priority: Major > > This is similar to Checkstyle (which we already use), but for Scala: > http://www.scalastyle.org/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KAFKA-2423) Introduce Scalastyle
[ https://issues.apache.org/jira/browse/KAFKA-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354661#comment-16354661 ] Ray Chiang commented on KAFKA-2423: --- [~granthenke], let me know if I can take this one over. > Introduce Scalastyle > > > Key: KAFKA-2423 > URL: https://issues.apache.org/jira/browse/KAFKA-2423 > Project: Kafka > Issue Type: Improvement >Reporter: Ismael Juma >Assignee: Grant Henke >Priority: Major > > This is similar to Checkstyle (which we already use), but for Scala: > http://www.scalastyle.org/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
