[jira] [Commented] (KAFKA-4083) ReassignPartitionsCommand does not check replication factor
[ https://issues.apache.org/jira/browse/KAFKA-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226284#comment-16226284 ] Simon Wan Wenli commented on KAFKA-4083: Is this patch still necessary? If so, I can resolve its conflicts. > ReassignPartitionsCommand does not check replication factor > --- > > Key: KAFKA-4083 > URL: https://issues.apache.org/jira/browse/KAFKA-4083 > Project: Kafka > Issue Type: Bug > Components: admin, core >Affects Versions: 0.8.2.0, 0.9.0.0, 0.10.0.0 > Environment: Linux 14.04 LTS, Scala 2.10 >Reporter: Simon Wan Wenli >Assignee: Simon Wan Wenli >Priority: Minor > Labels: newbie > Original Estimate: 48h > Remaining Estimate: 48h > > ReassignPartitionsCommand does not check whether the replication factor of a > partition is the same as existing replication factor, which may result that > different partitions of a topic have different number of replicas. More > specifically, TopicCommand will throw exception which contains "All > partitions should have the same number of replicas." as the message when the > user tries to add partitions. I think this loophole also may leave Kafka in a > situation from which it is difficult to recover. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-4083) ReassignPartitionsCommand does not check replication factor
[ https://issues.apache.org/jira/browse/KAFKA-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226194#comment-16226194 ] Ewen Cheslack-Postava commented on KAFKA-4083: -- Presumably it is https://github.com/apache/kafka/pull/1779 > ReassignPartitionsCommand does not check replication factor > --- > > Key: KAFKA-4083 > URL: https://issues.apache.org/jira/browse/KAFKA-4083 > Project: Kafka > Issue Type: Bug > Components: admin, core >Affects Versions: 0.8.2.0, 0.9.0.0, 0.10.0.0 > Environment: Linux 14.04 LTS, Scala 2.10 >Reporter: Simon Wan Wenli >Assignee: Simon Wan Wenli >Priority: Minor > Labels: newbie > Original Estimate: 48h > Remaining Estimate: 48h > > ReassignPartitionsCommand does not check whether the replication factor of a > partition is the same as existing replication factor, which may result that > different partitions of a topic have different number of replicas. More > specifically, TopicCommand will throw exception which contains "All > partitions should have the same number of replicas." as the message when the > user tries to add partitions. I think this loophole also may leave Kafka in a > situation from which it is difficult to recover. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-4083) ReassignPartitionsCommand does not check replication factor
[ https://issues.apache.org/jira/browse/KAFKA-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223613#comment-16223613 ] Ismael Juma commented on KAFKA-4083: This says "Patch Available", but there's no link to a PR. Can you please add it? > ReassignPartitionsCommand does not check replication factor > --- > > Key: KAFKA-4083 > URL: https://issues.apache.org/jira/browse/KAFKA-4083 > Project: Kafka > Issue Type: Bug > Components: admin, core >Affects Versions: 0.8.2.0, 0.9.0.0, 0.10.0.0 > Environment: Linux 14.04 LTS, Scala 2.10 >Reporter: Simon Wan Wenli >Assignee: Simon Wan Wenli >Priority: Minor > Labels: newbie > Original Estimate: 48h > Remaining Estimate: 48h > > ReassignPartitionsCommand does not check whether the replication factor of a > partition is the same as existing replication factor, which may result that > different partitions of a topic have different number of replicas. More > specifically, TopicCommand will throw exception which contains "All > partitions should have the same number of replicas." as the message when the > user tries to add partitions. I think this loophole also may leave Kafka in a > situation from which it is difficult to recover. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
