[jira] [Commented] (KAFKA-5379) ProcessorContext.appConfigs() should return parsed/validated values

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149150#comment-16149150
 ] 

ASF GitHub Bot commented on KAFKA-5379:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/3757


> ProcessorContext.appConfigs() should return parsed/validated values
> ---
>
> Key: KAFKA-5379
> URL: https://issues.apache.org/jira/browse/KAFKA-5379
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.10.2.1
>Reporter: Tommy Becker
>Assignee: Tommy Becker
>Priority: Minor
> Fix For: 1.0.0
>
>
> As part of KAFKA-5334, it was decided that the current behavior of 
> {{ProcessorContext.appConfigs()}} is sub-optimal in that it returns the 
> original unparsed config values. Alternatively, the parsed values could be 
> returned which would allow callers to know what they are getting as well 
> avoid duplicating type conversions (e.g. className -> class).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5379) ProcessorContext.appConfigs() should return parsed/validated values

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146165#comment-16146165
 ] 

ASF GitHub Bot commented on KAFKA-5379:
---

GitHub user guozhangwang opened a pull request:

https://github.com/apache/kafka/pull/3757

KAFKA-5379 follow up: reduce redundant mock processor context



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/guozhangwang/kafka K5379-follow-up

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3757.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3757


commit c750932d05559c3e7d28c64a1a334db680cfe77f
Author: Guozhang Wang 
Date:   2017-08-29T20:59:44Z

remove two test processor context into mock processor context

commit d2fc3853ff3caa6f10e9932e90b995ff5a4807ea
Author: Guozhang Wang 
Date:   2017-08-29T21:27:28Z

some reverts




> ProcessorContext.appConfigs() should return parsed/validated values
> ---
>
> Key: KAFKA-5379
> URL: https://issues.apache.org/jira/browse/KAFKA-5379
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.10.2.1
>Reporter: Tommy Becker
>Assignee: Tommy Becker
>Priority: Minor
> Fix For: 1.0.0
>
>
> As part of KAFKA-5334, it was decided that the current behavior of 
> {{ProcessorContext.appConfigs()}} is sub-optimal in that it returns the 
> original unparsed config values. Alternatively, the parsed values could be 
> returned which would allow callers to know what they are getting as well 
> avoid duplicating type conversions (e.g. className -> class).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5379) ProcessorContext.appConfigs() should return parsed/validated values

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146011#comment-16146011
 ] 

ASF GitHub Bot commented on KAFKA-5379:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/3455


> ProcessorContext.appConfigs() should return parsed/validated values
> ---
>
> Key: KAFKA-5379
> URL: https://issues.apache.org/jira/browse/KAFKA-5379
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.10.2.1
>Reporter: Tommy Becker
>Assignee: Tommy Becker
>Priority: Minor
> Fix For: 1.0.0
>
>
> As part of KAFKA-5334, it was decided that the current behavior of 
> {{ProcessorContext.appConfigs()}} is sub-optimal in that it returns the 
> original unparsed config values. Alternatively, the parsed values could be 
> returned which would allow callers to know what they are getting as well 
> avoid duplicating type conversions (e.g. className -> class).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5379) ProcessorContext.appConfigs() should return parsed/validated values

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066695#comment-16066695
 ] 

ASF GitHub Bot commented on KAFKA-5379:
---

GitHub user twbecker opened a pull request:

https://github.com/apache/kafka/pull/3455

KAFKA-5379 - ProcessorContext.appConfigs() should return parsed values.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twbecker/kafka kafka-5379

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3455


commit 8ce6197f8190c74b5c6cb665af86432daaf2
Author: Tommy Becker 
Date:   2017-06-28T15:06:21Z

KAFKA-5379 - ProcessorContext.appConfigs() should return parsed values.




> ProcessorContext.appConfigs() should return parsed/validated values
> ---
>
> Key: KAFKA-5379
> URL: https://issues.apache.org/jira/browse/KAFKA-5379
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.10.2.1
>Reporter: Tommy Becker
>Assignee: Tommy Becker
>Priority: Minor
>
> As part of KAFKA-5334, it was decided that the current behavior of 
> {{ProcessorContext.appConfigs()}} is sub-optimal in that it returns the 
> original unparsed config values. Alternatively, the parsed values could be 
> returned which would allow callers to know what they are getting as well 
> avoid duplicating type conversions (e.g. className -> class).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5379) ProcessorContext.appConfigs() should return parsed/validated values

[Guozhang Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061203#comment-16061203
 ] 

Guozhang Wang commented on KAFKA-5379:
--

[~twbecker] Could we make a pass over all the Type.CLASS configs in 
StreamsConfig and make sure users can either pass in a class name (for this 
case we should document that users any customized class with external 
dependency will not be supported as we are only relying on reflections) or 
class object, and the {{appConfigs}} can return the parsed objects as always in 
this JIRA?

Also note that we are adding a few more class typed configs cc [~enothereska] 
for serialization exception handler, we need to do the same for them.

> ProcessorContext.appConfigs() should return parsed/validated values
> ---
>
> Key: KAFKA-5379
> URL: https://issues.apache.org/jira/browse/KAFKA-5379
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.10.2.1
>Reporter: Tommy Becker
>Assignee: Tommy Becker
>Priority: Minor
>
> As part of KAFKA-5334, it was decided that the current behavior of 
> {{ProcessorContext.appConfigs()}} is sub-optimal in that it returns the 
> original unparsed config values. Alternatively, the parsed values could be 
> returned which would allow callers to know what they are getting as well 
> avoid duplicating type conversions (e.g. className -> class).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)