[jira] [Commented] (KAFKA-5584) Incorrect log size for topics larger than 2 GB

[Ismael Juma (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087170#comment-16087170
 ] 

Ismael Juma commented on KAFKA-5584:


Thanks for tracking it down [~kongo2002], that looks right to me.

> Incorrect log size for topics larger than 2 GB
> --
>
> Key: KAFKA-5584
> URL: https://issues.apache.org/jira/browse/KAFKA-5584
> Project: Kafka
>  Issue Type: Bug
>  Components: log
>Affects Versions: 0.11.0.0
>Reporter: Gregor Uhlenheuer
>Priority: Critical
>  Labels: reliability
> Fix For: 0.11.0.1
>
> Attachments: Screen Shot 2017-07-12 at 09.10.53.png
>
>
> The {{size}} of a {{Log}} is calculated incorrectly due to an Integer 
> overflow. For large topics (larger than 2 GB) this value overflows.
> This is easily observable in the reported metrics values of the path 
> {{log.Log.partition.*.topic..Size}} (see attached screenshot).
> Moreover I think this breaks the size-based retention (via 
> {{log.retention.bytes}} and {{retention.bytes}}) of large topics as well.
> I am not sure on the recommended workflow, should I open a pull request on 
> github with a fix?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5584) Incorrect log size for topics larger than 2 GB

[Gregor Uhlenheuer (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086986#comment-16086986
 ] 

Gregor Uhlenheuer commented on KAFKA-5584:
--

It seems the bug was introduced with commit 
{{e71dce89c0da50f3eccc47d0fc050c92d5a99b88}} I think.

> Incorrect log size for topics larger than 2 GB
> --
>
> Key: KAFKA-5584
> URL: https://issues.apache.org/jira/browse/KAFKA-5584
> Project: Kafka
>  Issue Type: Bug
>  Components: log
>Reporter: Gregor Uhlenheuer
>Priority: Critical
>  Labels: reliability
> Fix For: 0.11.0.1
>
> Attachments: Screen Shot 2017-07-12 at 09.10.53.png
>
>
> The {{size}} of a {{Log}} is calculated incorrectly due to an Integer 
> overflow. For large topics (larger than 2 GB) this value overflows.
> This is easily observable in the reported metrics values of the path 
> {{log.Log.partition.*.topic..Size}} (see attached screenshot).
> Moreover I think this breaks the size-based retention (via 
> {{log.retention.bytes}} and {{retention.bytes}}) of large topics as well.
> I am not sure on the recommended workflow, should I open a pull request on 
> github with a fix?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5584) Incorrect log size for topics larger than 2 GB

[Michal Borowiecki (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085542#comment-16085542
 ] 

Michal Borowiecki commented on KAFKA-5584:
--

Was this a regression in 0.11.0.0 specifically?

> Incorrect log size for topics larger than 2 GB
> --
>
> Key: KAFKA-5584
> URL: https://issues.apache.org/jira/browse/KAFKA-5584
> Project: Kafka
>  Issue Type: Bug
>  Components: log
>Reporter: Gregor Uhlenheuer
>Priority: Critical
>  Labels: reliability
> Fix For: 0.11.0.1
>
> Attachments: Screen Shot 2017-07-12 at 09.10.53.png
>
>
> The {{size}} of a {{Log}} is calculated incorrectly due to an Integer 
> overflow. For large topics (larger than 2 GB) this value overflows.
> This is easily observable in the reported metrics values of the path 
> {{log.Log.partition.*.topic..Size}} (see attached screenshot).
> Moreover I think this breaks the size-based retention (via 
> {{log.retention.bytes}} and {{retention.bytes}}) of large topics as well.
> I am not sure on the recommended workflow, should I open a pull request on 
> github with a fix?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5584) Incorrect log size for topics larger than 2 GB

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084980#comment-16084980
 ] 

ASF GitHub Bot commented on KAFKA-5584:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/3521


> Incorrect log size for topics larger than 2 GB
> --
>
> Key: KAFKA-5584
> URL: https://issues.apache.org/jira/browse/KAFKA-5584
> Project: Kafka
>  Issue Type: Bug
>  Components: log
>Reporter: Gregor Uhlenheuer
>Priority: Critical
>  Labels: reliability
> Fix For: 0.11.0.1
>
> Attachments: Screen Shot 2017-07-12 at 09.10.53.png
>
>
> The {{size}} of a {{Log}} is calculated incorrectly due to an Integer 
> overflow. For large topics (larger than 2 GB) this value overflows.
> This is easily observable in the reported metrics values of the path 
> {{log.Log.partition.*.topic..Size}} (see attached screenshot).
> Moreover I think this breaks the size-based retention (via 
> {{log.retention.bytes}} and {{retention.bytes}}) of large topics as well.
> I am not sure on the recommended workflow, should I open a pull request on 
> github with a fix?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5584) Incorrect log size for topics larger than 2 GB

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083753#comment-16083753
 ] 

ASF GitHub Bot commented on KAFKA-5584:
---

GitHub user kongo2002 opened a pull request:

https://github.com/apache/kafka/pull/3521

KAFKA-5584: fix integer overflow in Log.size

As described in 
[KAFKA-5584](https://issues.apache.org/jira/browse/KAFKA-5584) the integer 
overflow in `Log.size` may lead to wrong metrics and broken size-based 
retention via `log.retention.bytes` or `retention.bytes` on rather large topic 
partitions.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kongo2002/kafka KAFKA-5584

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3521.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3521


commit 4ba20618a13dfd6c16b8228b319a21ae1915e857
Author: Gregor Uhlenheuer 
Date:   2017-07-12T10:07:49Z

KAFKA-5584: fix integer overflow in Log.size




> Incorrect log size for topics larger than 2 GB
> --
>
> Key: KAFKA-5584
> URL: https://issues.apache.org/jira/browse/KAFKA-5584
> Project: Kafka
>  Issue Type: Bug
>  Components: log
>Reporter: Gregor Uhlenheuer
> Attachments: Screen Shot 2017-07-12 at 09.10.53.png
>
>
> The {{size}} of a {{Log}} is calculated incorrectly due to an Integer 
> overflow. For large topics (larger than 2 GB) this value overflows.
> This is easily observable in the reported metrics values of the path 
> {{log.Log.partition.*.topic..Size}} (see attached screenshot).
> Moreover I think this breaks the size-based retention (via 
> {{log.retention.bytes}} and {{retention.bytes}}) of large topics as well.
> I am not sure on the recommended workflow, should I open a pull request on 
> github with a fix?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5584) Incorrect log size for topics larger than 2 GB

[Gregor Uhlenheuer (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083582#comment-16083582
 ] 

Gregor Uhlenheuer commented on KAFKA-5584:
--

Sorry, I missed that information. I am using kafka {{0.11.0.0}}.

> Incorrect log size for topics larger than 2 GB
> --
>
> Key: KAFKA-5584
> URL: https://issues.apache.org/jira/browse/KAFKA-5584
> Project: Kafka
>  Issue Type: Bug
>  Components: log
>Reporter: Gregor Uhlenheuer
> Attachments: Screen Shot 2017-07-12 at 09.10.53.png
>
>
> The {{size}} of a {{Log}} is calculated incorrectly due to an Integer 
> overflow. For large topics (larger than 2 GB) this value overflows.
> This is easily observable in the reported metrics values of the path 
> {{log.Log.partition.*.topic..Size}} (see attached screenshot).
> Moreover I think this breaks the size-based retention (via 
> {{log.retention.bytes}} and {{retention.bytes}}) of large topics as well.
> I am not sure on the recommended workflow, should I open a pull request on 
> github with a fix?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5584) Incorrect log size for topics larger than 2 GB

[Jeff Widman (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083580#comment-16083580
 ] 

Jeff Widman commented on KAFKA-5584:


What version of Kafka did you observe this on?

> Incorrect log size for topics larger than 2 GB
> --
>
> Key: KAFKA-5584
> URL: https://issues.apache.org/jira/browse/KAFKA-5584
> Project: Kafka
>  Issue Type: Bug
>  Components: log
>Reporter: Gregor Uhlenheuer
> Attachments: Screen Shot 2017-07-12 at 09.10.53.png
>
>
> The {{size}} of a {{Log}} is calculated incorrectly due to an Integer 
> overflow. For large topics (larger than 2 GB) this value overflows.
> This is easily observable in the reported metrics values of the path 
> {{log.Log.partiion.*.topic..Size}} (see attached screenshot).
> Moreover I think this breaks the size-based retention (via 
> {{log.retention.bytes}} and {{retention.bytes}}) of large topics as well.
> I am not sure on the recommended workflow, should I open a pull request on 
> github with a fix?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)