[jira] [Commented] (KAFKA-5603) Streams should not abort transaction when closing zombie task

[Matthias J. Sax (Jira)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058039#comment-17058039
 ] 

Matthias J. Sax commented on KAFKA-5603:


Well, nobody worked on KAFKA-5604 and hence it would be nice to get it fixed.

The point being is that after the producer got fenced, `abortTransaction()` 
should not be called what Streams did, but we fixed it. I can't remember if the 
call to `abortTransaction` resulted in another `ProducerFencedException` or a 
`KafkaException` (due to KAFKA-5604). But for this ticket it does not really 
matter as an exception would be thrown anyway if the call is made and thus we 
now don't make the call any longer.

> Streams should not abort transaction when closing zombie task
> -
>
> Key: KAFKA-5603
> URL: https://issues.apache.org/jira/browse/KAFKA-5603
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.11.0.0
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Critical
> Fix For: 0.11.0.1, 1.0.0
>
>
> The contract of the transactional producer API is to not call any 
> transactional method after a {{ProducerFenced}} exception was thrown.
> Streams however, does an unconditional call within {{StreamTask#close()}} to 
> {{abortTransaction()}} in case of unclean shutdown. We need to distinguish 
> between a {{ProducerFenced}} and other unclean shutdown cases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (KAFKA-5603) Streams should not abort transaction when closing zombie task

[Xiang Zhang (Jira)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057942#comment-17057942
 ] 

Xiang Zhang commented on KAFKA-5603:


[~mjsax] How is this ticket related to KAFKA-5604? Does KAFKA-5604 need more 
work ?

> Streams should not abort transaction when closing zombie task
> -
>
> Key: KAFKA-5603
> URL: https://issues.apache.org/jira/browse/KAFKA-5603
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.11.0.0
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Critical
> Fix For: 0.11.0.1, 1.0.0
>
>
> The contract of the transactional producer API is to not call any 
> transactional method after a {{ProducerFenced}} exception was thrown.
> Streams however, does an unconditional call within {{StreamTask#close()}} to 
> {{abortTransaction()}} in case of unclean shutdown. We need to distinguish 
> between a {{ProducerFenced}} and other unclean shutdown cases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (KAFKA-5603) Streams should not abort transaction when closing zombie task

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154514#comment-16154514
 ] 

ASF GitHub Bot commented on KAFKA-5603:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/3719


> Streams should not abort transaction when closing zombie task
> -
>
> Key: KAFKA-5603
> URL: https://issues.apache.org/jira/browse/KAFKA-5603
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.11.0.0
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Critical
> Fix For: 0.11.0.1
>
>
> The contract of the transactional producer API is to not call any 
> transactional method after a {{ProducerFenced}} exception was thrown.
> Streams however, does an unconditional call within {{StreamTask#close()}} to 
> {{abortTransaction()}} in case of unclean shutdown. We need to distinguish 
> between a {{ProducerFenced}} and other unclean shutdown cases.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5603) Streams should not abort transaction when closing zombie task

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137706#comment-16137706
 ] 

ASF GitHub Bot commented on KAFKA-5603:
---

GitHub user mjsax opened a pull request:

https://github.com/apache/kafka/pull/3722

KAFKA-5603: Don't abort TX for zombie tasks



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mjsax/kafka 
kafka-5603-dont-abort-tx-for-zombie-tasks-01101

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3722.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3722


commit 72cff12f2274eb16f44fde85dcc7d5ff30614a3f
Author: Matthias J. Sax 
Date:   2017-08-23T01:06:32Z

KAFKA-5603: Don't abort TX for zombie tasks




> Streams should not abort transaction when closing zombie task
> -
>
> Key: KAFKA-5603
> URL: https://issues.apache.org/jira/browse/KAFKA-5603
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.11.0.0
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Critical
> Fix For: 0.11.0.1
>
>
> The contract of the transactional producer API is to not call any 
> transactional method after a {{ProducerFenced}} exception was thrown.
> Streams however, does an unconditional call within {{StreamTask#close()}} to 
> {{abortTransaction()}} in case of unclean shutdown. We need to distinguish 
> between a {{ProducerFenced}} and other unclean shutdown cases.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5603) Streams should not abort transaction when closing zombie task

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137647#comment-16137647
 ] 

ASF GitHub Bot commented on KAFKA-5603:
---

GitHub user mjsax opened a pull request:

https://github.com/apache/kafka/pull/3719

KAFKA-5603: Don't abort TX for zombie tasks



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mjsax/kafka 
kafka-5603-dont-abort-tx-for-zombie-tasks-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3719.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3719


commit d1814d2e657dea4fb37b98305cc0f960119a123f
Author: Matthias J. Sax 
Date:   2017-08-23T00:09:52Z

KAFKA-5603: Don't abort TX for zombie tasks




> Streams should not abort transaction when closing zombie task
> -
>
> Key: KAFKA-5603
> URL: https://issues.apache.org/jira/browse/KAFKA-5603
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.11.0.0
>Reporter: Matthias J. Sax
>Assignee: Matthias J. Sax
>Priority: Critical
> Fix For: 0.11.0.1
>
>
> The contract of the transactional producer API is to not call any 
> transactional method after a {{ProducerFenced}} exception was thrown.
> Streams however, does an unconditional call within {{StreamTask#close()}} to 
> {{abortTransaction()}} in case of unclean shutdown. We need to distinguish 
> between a {{ProducerFenced}} and other unclean shutdown cases.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)