[jira] [Commented] (KAFKA-6259) Make KafkaStreams.cleanup() clean global state directory

2017-11-29 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271390#comment-16271390
 ] 

ASF GitHub Bot commented on KAFKA-6259:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/4255


> Make KafkaStreams.cleanup() clean global state directory
> 
>
> Key: KAFKA-6259
> URL: https://issues.apache.org/jira/browse/KAFKA-6259
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 1.0.0, 0.11.0.2
>Reporter: Damian Guy
>Assignee: Matthias J. Sax
> Fix For: 1.1.0
>
>
> We have {{KafkaStreams#cleanUp}} so that developers can remove all local 
> state during development, i.e., so they can start from a clean slate. 
> However, this presently doesn't cleanup the global state directory



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-6259) Make KafkaStreams.cleanup() clean global state directory

2017-11-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263514#comment-16263514
 ] 

ASF GitHub Bot commented on KAFKA-6259:
---

GitHub user mjsax opened a pull request:

https://github.com/apache/kafka/pull/4255

KAFKA-6259: Make KafkaStreams.cleanup() clean global state directory


### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mjsax/kafka kafka-6259-clean-global-state-dir

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4255.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4255


commit 6f910fbe3fea9e49501309f977441b756ead7bc0
Author: Matthias J. Sax 
Date:   2017-11-22T22:53:16Z

KAFKA-6259: Make KafkaStreams.cleanup() clean global state directory




> Make KafkaStreams.cleanup() clean global state directory
> 
>
> Key: KAFKA-6259
> URL: https://issues.apache.org/jira/browse/KAFKA-6259
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.11.0.2, 1.0, 1.0.1
>Reporter: Damian Guy
>Assignee: Matthias J. Sax
>
> We have {{KafkaStreams#cleanUp}} so that developers can remove all local 
> state during development, i.e., so they can start from a clean slate. 
> However, this presently doesn't cleanup the global state directory



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-6259) Make KafkaStreams.cleanup() clean global state directory

2017-11-22 Thread Tommy Becker (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262987#comment-16262987
 ] 

Tommy Becker commented on KAFKA-6259:
-

I literally just noticed this yesterday, and was wondering if it was a 
deliberate omission. 

> Make KafkaStreams.cleanup() clean global state directory
> 
>
> Key: KAFKA-6259
> URL: https://issues.apache.org/jira/browse/KAFKA-6259
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.11.0.2, 1.0, 1.0.1
>Reporter: Damian Guy
>
> We have {{KafkaStreams#cleanUp}} so that developers can remove all local 
> state during development, i.e., so they can start from a clean slate. 
> However, this presently doesn't cleanup the global state directory



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)