[jira] [Commented] (KAFKA-7798) Expose embedded client context from KafkaStreams threadMetadata
[ https://issues.apache.org/jira/browse/KAFKA-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758884#comment-16758884 ] ASF GitHub Bot commented on KAFKA-7798: --- mjsax commented on pull request #6107: KAFKA-7798: Expose embedded clientIds URL: https://github.com/apache/kafka/pull/6107 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expose embedded client context from KafkaStreams threadMetadata > --- > > Key: KAFKA-7798 > URL: https://issues.apache.org/jira/browse/KAFKA-7798 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Guozhang Wang >Assignee: Guozhang Wang >Priority: Major > Labels: kip > > A KafkaStreams client today contains multiple embedded clients: producer, > consumer and admin client. Currently these client's context like client id > are not exposed via KafkaStreams. This ticket proposes to expose those > context information at the per-thread basis (since each thread has its own > embedded clients) via ThreadMetadata. > This also has an interplay with KIP-345: as we add group.instance.id in that > KIP, this information should also be exposed as well. > Cf: > [https://cwiki.apache.org/confluence/display/KAFKA/KIP-414%3A+Expose+Embedded+ClientIds+in+Kafka+Streams] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KAFKA-7798) Expose embedded client context from KafkaStreams threadMetadata
[ https://issues.apache.org/jira/browse/KAFKA-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738675#comment-16738675 ] Guozhang Wang commented on KAFKA-7798: -- I've filed a KIP-414 here :) I'm linking the wiki now. > Expose embedded client context from KafkaStreams threadMetadata > --- > > Key: KAFKA-7798 > URL: https://issues.apache.org/jira/browse/KAFKA-7798 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Guozhang Wang >Assignee: Guozhang Wang >Priority: Major > > A KafkaStreams client today contains multiple embedded clients: producer, > consumer and admin client. Currently these client's context like client id > are not exposed via KafkaStreams. This ticket proposes to expose those > context information at the per-thread basis (since each thread has its own > embedded clients) via ThreadMetadata. > This also has an interplay with KIP-345: as we add group.instance.id in that > KIP, this information should also be exposed as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KAFKA-7798) Expose embedded client context from KafkaStreams threadMetadata
[ https://issues.apache.org/jira/browse/KAFKA-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738163#comment-16738163 ] Matthias J. Sax commented on KAFKA-7798: Sounds like a public API change – is this part of KIP-345 or do we need a KIP for this ticket? > Expose embedded client context from KafkaStreams threadMetadata > --- > > Key: KAFKA-7798 > URL: https://issues.apache.org/jira/browse/KAFKA-7798 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Guozhang Wang >Assignee: Guozhang Wang >Priority: Major > > A KafkaStreams client today contains multiple embedded clients: producer, > consumer and admin client. Currently these client's context like client id > are not exposed via KafkaStreams. This ticket proposes to expose those > context information at the per-thread basis (since each thread has its own > embedded clients) via ThreadMetadata. > This also has an interplay with KIP-345: as we add group.instance.id in that > KIP, this information should also be exposed as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KAFKA-7798) Expose embedded client context from KafkaStreams threadMetadata
[ https://issues.apache.org/jira/browse/KAFKA-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737767#comment-16737767 ] ASF GitHub Bot commented on KAFKA-7798: --- guozhangwang commented on pull request #6107: KAFKA-7798: expose embedded client context URL: https://github.com/apache/kafka/pull/6107 1. Add consumer / restoreConsumer / producer(s) / admin client ids via ThreadMetadata; for producerIds, if EOS is turned on add the list of task-producer-ids, otherwise it is a singleton of thread-producer-id. 2. Consolidate the logic of generating clientIds from thread names and client id into StreamThread. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Expose embedded client context from KafkaStreams threadMetadata > --- > > Key: KAFKA-7798 > URL: https://issues.apache.org/jira/browse/KAFKA-7798 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Guozhang Wang >Assignee: Guozhang Wang >Priority: Major > > A KafkaStreams client today contains multiple embedded clients: producer, > consumer and admin client. Currently these client's context like client id > are not exposed via KafkaStreams. This ticket proposes to expose those > context information at the per-thread basis (since each thread has its own > embedded clients) via ThreadMetadata. > This also has an interplay with KIP-345: as we add group.instance.id in that > KIP, this information should also be exposed as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KAFKA-7798) Expose embedded client context from KafkaStreams threadMetadata
[ https://issues.apache.org/jira/browse/KAFKA-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737595#comment-16737595 ] Boyang Chen commented on KAFKA-7798: Great speed! > Expose embedded client context from KafkaStreams threadMetadata > --- > > Key: KAFKA-7798 > URL: https://issues.apache.org/jira/browse/KAFKA-7798 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Guozhang Wang >Assignee: Guozhang Wang >Priority: Major > > A KafkaStreams client today contains multiple embedded clients: producer, > consumer and admin client. Currently these client's context like client id > are not exposed via KafkaStreams. This ticket proposes to expose those > context information at the per-thread basis (since each thread has its own > embedded clients) via ThreadMetadata. > This also has an interplay with KIP-345: as we add group.instance.id in that > KIP, this information should also be exposed as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
