[jira] [Commented] (KAFKA-8024) UtilsTest.testFormatBytes fails with german locale
[
https://issues.apache.org/jira/browse/KAFKA-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886689#comment-16886689
]
ASF GitHub Bot commented on KAFKA-8024:
---
hachikuji commented on pull request #6351: KAFKA-8024: Set locale to enUS for
tests
URL: https://github.com/apache/kafka/pull/6351
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> UtilsTest.testFormatBytes fails with german locale
> --
>
> Key: KAFKA-8024
> URL: https://issues.apache.org/jira/browse/KAFKA-8024
> Project: Kafka
> Issue Type: Bug
>Reporter: Patrik Kleindl
>Assignee: Patrik Kleindl
>Priority: Trivial
>
> The unit test fails when the default locale is not English (in my case, deAT)
> assertEquals("1.1 MB", formatBytes((long) (1.1 * 1024 * 1024)));
>
> org.apache.kafka.common.utils.UtilsTest > testFormatBytes FAILED
> org.junit.ComparisonFailure: expected:<1[.]1 MB> but was:<1[,]1 MB>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.kafka.common.utils.UtilsTest.testFormatBytes(UtilsTest.java:106)
>
> The easiest fix in this case should be adding
> {code:java}
> jvmArgs '-Duser.language=en -Duser.country=US'{code}
> to the test configuration
> [https://github.com/apache/kafka/blob/b03e8c234a8aeecd10c2c96b683cfb39b24b548a/build.gradle#L270]
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (KAFKA-8024) UtilsTest.testFormatBytes fails with german locale
[
https://issues.apache.org/jira/browse/KAFKA-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885284#comment-16885284
]
Patrik Kleindl commented on KAFKA-8024:
---
[~sujayopensource] You need to ask for permissions on the mailing list.
I have assigned this to myself now as a PR is already available.
> UtilsTest.testFormatBytes fails with german locale
> --
>
> Key: KAFKA-8024
> URL: https://issues.apache.org/jira/browse/KAFKA-8024
> Project: Kafka
> Issue Type: Bug
>Reporter: Patrik Kleindl
>Assignee: Patrik Kleindl
>Priority: Trivial
>
> The unit test fails when the default locale is not English (in my case, deAT)
> assertEquals("1.1 MB", formatBytes((long) (1.1 * 1024 * 1024)));
>
> org.apache.kafka.common.utils.UtilsTest > testFormatBytes FAILED
> org.junit.ComparisonFailure: expected:<1[.]1 MB> but was:<1[,]1 MB>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.kafka.common.utils.UtilsTest.testFormatBytes(UtilsTest.java:106)
>
> The easiest fix in this case should be adding
> {code:java}
> jvmArgs '-Duser.language=en -Duser.country=US'{code}
> to the test configuration
> [https://github.com/apache/kafka/blob/b03e8c234a8aeecd10c2c96b683cfb39b24b548a/build.gradle#L270]
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (KAFKA-8024) UtilsTest.testFormatBytes fails with german locale
[
https://issues.apache.org/jira/browse/KAFKA-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884382#comment-16884382
]
Sujay Hegde commented on KAFKA-8024:
Hi,
I am a newbie.
How do I assign this issue to myself?
I deem it to be a trivial issue and a good starting point to contribute to
kafka.
Thanks
> UtilsTest.testFormatBytes fails with german locale
> --
>
> Key: KAFKA-8024
> URL: https://issues.apache.org/jira/browse/KAFKA-8024
> Project: Kafka
> Issue Type: Bug
>Reporter: Patrik Kleindl
>Priority: Trivial
>
> The unit test fails when the default locale is not English (in my case, deAT)
> assertEquals("1.1 MB", formatBytes((long) (1.1 * 1024 * 1024)));
>
> org.apache.kafka.common.utils.UtilsTest > testFormatBytes FAILED
> org.junit.ComparisonFailure: expected:<1[.]1 MB> but was:<1[,]1 MB>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.kafka.common.utils.UtilsTest.testFormatBytes(UtilsTest.java:106)
>
> The easiest fix in this case should be adding
> {code:java}
> jvmArgs '-Duser.language=en -Duser.country=US'{code}
> to the test configuration
> [https://github.com/apache/kafka/blob/b03e8c234a8aeecd10c2c96b683cfb39b24b548a/build.gradle#L270]
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (KAFKA-8024) UtilsTest.testFormatBytes fails with german locale
[
https://issues.apache.org/jira/browse/KAFKA-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16781553#comment-16781553
]
ASF GitHub Bot commented on KAFKA-8024:
---
pkleindl commented on pull request #6351: KAFKA-8024: Set locale to enUS for
tests
URL: https://github.com/apache/kafka/pull/6351
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> UtilsTest.testFormatBytes fails with german locale
> --
>
> Key: KAFKA-8024
> URL: https://issues.apache.org/jira/browse/KAFKA-8024
> Project: Kafka
> Issue Type: Bug
>Reporter: Patrik Kleindl
>Priority: Trivial
>
> The unit test fails when the default locale is not English (in my case, deAT)
> assertEquals("1.1 MB", formatBytes((long) (1.1 * 1024 * 1024)));
>
> org.apache.kafka.common.utils.UtilsTest > testFormatBytes FAILED
> org.junit.ComparisonFailure: expected:<1[.]1 MB> but was:<1[,]1 MB>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.kafka.common.utils.UtilsTest.testFormatBytes(UtilsTest.java:106)
>
> The easiest fix in this case should be adding
> {code:java}
> jvmArgs '-Duser.language=en -Duser.country=US'{code}
> to the test configuration
> [https://github.com/apache/kafka/blob/b03e8c234a8aeecd10c2c96b683cfb39b24b548a/build.gradle#L270]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
