[
https://issues.apache.org/jira/browse/KAFKA-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794523#comment-16794523
]
ASF GitHub Bot commented on KAFKA-8118:
---
rajinisivaram commented on pull request #6456: KAFKA-8118; Ensure ZooKeeper
clients are closed in tests, fix verification
URL: https://github.com/apache/kafka/pull/6456
We verify that ZK clients are closed in tests since these can affect
subsequent tests and that makes it hard to debug test failures. But because of
changes to ZooKeeper client, we are now checking the wrong thread name. The
thread name used now is `-EventThread` where
`creatorThreadName` varies depending on the test. Fixed verification
`ZooKeeperTestHarness` to check this format and fixed tests which were leaving
ZK clients behind. Also added a test to make sure we can detect changes to the
thread name when we update ZK clients in future.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ensure that tests close ZooKeeper clients since they can impact subsequent
> tests
>
>
> Key: KAFKA-8118
> URL: https://issues.apache.org/jira/browse/KAFKA-8118
> Project: Kafka
> Issue Type: Test
> Components: core
>Reporter: Rajini Sivaram
>Assignee: Rajini Sivaram
>Priority: Major
> Fix For: 2.3.0, 2.2.1
>
>
> A while ago, we added a check to verify that tests are closing ZooKeeper
> clients in ZooKeeperTestHarness since left over clients can impact subsequent
> tests (e.g by overwriting static JAAS configuration). But we have changed the
> ZK client since then and hence the thread name being verified is no longer
> correct. As a result, we have tests that are leaving ZK clients behind and we
> need to fix that (as well as the incorrect verification).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
