[jira] [Commented] (KAFKA-8238) Log how many bytes and messages were read from __consumer_offsets

2019-05-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KAFKA-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832523#comment-16832523
 ] 

ASF GitHub Bot commented on KAFKA-8238:
---

vamossagar12 commented on pull request #6669: KAFKA-8238: Adding Number of 
messages/bytes read
URL: https://github.com/apache/kafka/pull/6669
 
 
   This PR includes changes to count the number of messages/bytes read while 
loading offsets from TopicPartition.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Log how many bytes and messages were read from __consumer_offsets
> -
>
> Key: KAFKA-8238
> URL: https://issues.apache.org/jira/browse/KAFKA-8238
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Colin P. McCabe
>Assignee: Sagar Rao
>Priority: Minor
>  Labels: newbie
>
> We should log how many bytes and messages were read from __consumer_offsets.  
> Currently we only log how long it took.  Example: 
> {code}
> [GroupMetadataManager brokerId=2] Finished loading offsets and group metadata 
> from __consumer_offsets-22 in 23131 milliseconds.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KAFKA-8238) Log how many bytes and messages were read from __consumer_offsets

2019-05-01 Thread SuryaTeja Duggi (JIRA)


[ 
https://issues.apache.org/jira/browse/KAFKA-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831161#comment-16831161
 ] 

SuryaTeja Duggi commented on KAFKA-8238:


Hi [~cmccabe] could you add me as "contributors" role in Kafka's JIRA instance. 
I am new and getting started :)

> Log how many bytes and messages were read from __consumer_offsets
> -
>
> Key: KAFKA-8238
> URL: https://issues.apache.org/jira/browse/KAFKA-8238
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Colin P. McCabe
>Assignee: Sagar Rao
>Priority: Minor
>  Labels: newbie
>
> We should log how many bytes and messages were read from __consumer_offsets.  
> Currently we only log how long it took.  Example: 
> {code}
> [GroupMetadataManager brokerId=2] Finished loading offsets and group metadata 
> from __consumer_offsets-22 in 23131 milliseconds.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KAFKA-8238) Log how many bytes and messages were read from __consumer_offsets

2019-04-29 Thread Sagar Rao (JIRA)


[ 
https://issues.apache.org/jira/browse/KAFKA-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829426#comment-16829426
 ] 

Sagar Rao commented on KAFKA-8238:
--

Thanks [~cmccabe]. I started looking at the code to analyse what needs to be 
done.

1 thing that I wanted to know is that, is this feature something that needs to 
be enabled only for newer version(specifically for magic numbers = 2)? If 
that's the case, then I think we can compute the bytes and message read within 
the iterator:

[https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala#L557]

> Log how many bytes and messages were read from __consumer_offsets
> -
>
> Key: KAFKA-8238
> URL: https://issues.apache.org/jira/browse/KAFKA-8238
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Colin P. McCabe
>Assignee: Sagar Rao
>Priority: Minor
>  Labels: newbie
>
> We should log how many bytes and messages were read from __consumer_offsets.  
> Currently we only log how long it took.  Example: 
> {code}
> [GroupMetadataManager brokerId=2] Finished loading offsets and group metadata 
> from __consumer_offsets-22 in 23131 milliseconds.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KAFKA-8238) Log how many bytes and messages were read from __consumer_offsets

2019-04-27 Thread Colin P. McCabe (JIRA)


[ 
https://issues.apache.org/jira/browse/KAFKA-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827710#comment-16827710
 ] 

Colin P. McCabe commented on KAFKA-8238:


I added you to the "contributors" role in Kafka's JIRA instance.  You should be 
able to assign JIRAs to yourself now :)

> Log how many bytes and messages were read from __consumer_offsets
> -
>
> Key: KAFKA-8238
> URL: https://issues.apache.org/jira/browse/KAFKA-8238
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Colin P. McCabe
>Assignee: Sagar Rao
>Priority: Minor
>  Labels: newbie
>
> We should log how many bytes and messages were read from __consumer_offsets.  
> Currently we only log how long it took.  Example: 
> {code}
> [GroupMetadataManager brokerId=2] Finished loading offsets and group metadata 
> from __consumer_offsets-22 in 23131 milliseconds.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KAFKA-8238) Log how many bytes and messages were read from __consumer_offsets

2019-04-22 Thread Sagar Rao (JIRA)


[ 
https://issues.apache.org/jira/browse/KAFKA-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823168#comment-16823168
 ] 

Sagar Rao commented on KAFKA-8238:
--

Hi [~cmccabe] I am a new committer to Kafka project. I wanted to start with 
this ticket however I am unable to assign it to myself. 

> Log how many bytes and messages were read from __consumer_offsets
> -
>
> Key: KAFKA-8238
> URL: https://issues.apache.org/jira/browse/KAFKA-8238
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Colin P. McCabe
>Priority: Minor
>  Labels: newbie
>
> We should log how many bytes and messages were read from __consumer_offsets.  
> Currently we only log how long it took.  Example: 
> {code}
> [GroupMetadataManager brokerId=2] Finished loading offsets and group metadata 
> from __consumer_offsets-22 in 23131 milliseconds.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)