[
https://issues.apache.org/jira/browse/KAFKA-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827164#comment-16827164
]
ASF GitHub Bot commented on KAFKA-8294:
---
hachikuji commented on pull request #6642: KAFKA-8294; Batch StopReplica
requests when possible and improve test coverage
URL: https://github.com/apache/kafka/pull/6642
The main problem we are trying to solve here is the batching of StopReplica
requests and the lack of test coverage for `ControllerChannelManager`.
Addressing the first problem was straightforward, but the second problem
required quite a bit of work because of the dependence on `KafkaController` for
all of the events. It seemed to make sense to separate the events from the
processing of events so that we could remove this dependence and improve
testability. With the refactoring, I was able to add test cases covering most
of the logic in `ControllerChannelManager` including the generation of requests
and the expected response handling logic. Note that I have not actually changed
any of the event handling logic in `KafkaController`.
While refactoring this logic, I found that the event queue time metric was
not being correctly computed. The problem is that many of the controller events
were singleton objects which inherited the `enqueueTimeMs` field from the
`ControllerEvent` trait. This would never get updated, so queue time would be
skewed.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Batch StopReplica requests with partition deletion and add test cases
> -
>
> Key: KAFKA-8294
> URL: https://issues.apache.org/jira/browse/KAFKA-8294
> Project: Kafka
> Issue Type: Improvement
>Reporter: Jason Gustafson
>Assignee: Jason Gustafson
>Priority: Major
>
> One of the tricky aspects we found in KAFKA-8237 is the batching of the
> StopReplica requests. We should have test cases covering expected behavior so
> that we do not introduce regressions and we should make the batching
> consistent whether or not `deletePartitions` is set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
