[jira] [Commented] (KAFKA-8363) Config provider parsing is broken

2019-05-14 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KAFKA-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839724#comment-16839724
 ] 

ASF GitHub Bot commented on KAFKA-8363:
---

rhauch commented on pull request #6726: KAFKA-8363: Fix parsing bug for config 
providers
URL: https://github.com/apache/kafka/pull/6726
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Config provider parsing is broken
> -
>
> Key: KAFKA-8363
> URL: https://issues.apache.org/jira/browse/KAFKA-8363
> Project: Kafka
>  Issue Type: Bug
>Affects Versions: 2.0.0, 2.0.1, 2.1.0, 2.2.0, 2.1.1
>Reporter: Chris Egerton
>Assignee: Chris Egerton
>Priority: Major
>
> The 
> [regex|https://github.com/apache/kafka/blob/63e4f67d9ba9e08bdce705b35c5acf32dcd20633/clients/src/main/java/org/apache/kafka/common/config/ConfigTransformer.java#L56]
>  used by the {{ConfigTransformer}} class to parse config provider syntax (see 
> [KIP-279|https://cwiki.apache.org/confluence/display/KAFKA/KIP-297%3A+Externalizing+Secrets+for+Connect+Configurations])
>  is broken and fails when multiple path-less configs are specified. For 
> example: {{"${provider:configOne} ${provider:configTwo}"}} would be parsed 
> incorrectly as a reference with a path of {{"configOne} $\{provider"}}. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KAFKA-8363) Config provider parsing is broken

2019-05-13 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KAFKA-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838995#comment-16838995
 ] 

ASF GitHub Bot commented on KAFKA-8363:
---

C0urante commented on pull request #6726: KAFKA-8363: Fix parsing bug for 
config providers
URL: https://github.com/apache/kafka/pull/6726
 
 
   [Jira](https://issues.apache.org/jira/browse/KAFKA-8363)
   
   The regex used to parse config provider syntax can fail to accurately parse 
provided configurations when multiple path-less configs are requested (e.g., 
`${provider:pathOne} ${provider:pathTwo}`). This change fixes that parsing and 
adds a unit test to prevent regression.
   
   This bug is present since the addition of config providers and so should be 
backported through to 2.0, when they were first added.
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Config provider parsing is broken
> -
>
> Key: KAFKA-8363
> URL: https://issues.apache.org/jira/browse/KAFKA-8363
> Project: Kafka
>  Issue Type: Bug
>Affects Versions: 2.0.0, 2.0.1, 2.1.0, 2.2.0, 2.1.1
>Reporter: Chris Egerton
>Assignee: Chris Egerton
>Priority: Major
>
> The 
> [regex|https://github.com/apache/kafka/blob/63e4f67d9ba9e08bdce705b35c5acf32dcd20633/clients/src/main/java/org/apache/kafka/common/config/ConfigTransformer.java#L56]
>  used by the {{ConfigTransformer}} class to parse config provider syntax (see 
> [KIP-279|https://cwiki.apache.org/confluence/display/KAFKA/KIP-297%3A+Externalizing+Secrets+for+Connect+Configurations])
>  is broken and fails when multiple path-less configs are specified. For 
> example: {{"${provider:configOne} ${provider:configTwo}"}} would be parsed 
> incorrectly as a reference with a path of {{"configOne} $\{provider"}}. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)