[jira] [Commented] (KAFKA-9471) Throw exception for DEAD StreamThread.State
[ https://issues.apache.org/jira/browse/KAFKA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022980#comment-17022980 ] Vito Jeng commented on KAFKA-9471: -- [~yuzhih...@gmail.com] Yes, I would be include this in KIP-216. > Throw exception for DEAD StreamThread.State > --- > > Key: KAFKA-9471 > URL: https://issues.apache.org/jira/browse/KAFKA-9471 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > > In StreamThreadStateStoreProvider we have: > {code} > if (streamThread.state() == StreamThread.State.DEAD) { > return Collections.emptyList(); > {code} > If user cannot retry anymore, we should throw exception which is handled in > the else block. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9471) Throw exception for DEAD StreamThread.State
[ https://issues.apache.org/jira/browse/KAFKA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022970#comment-17022970 ] Ted Yu commented on KAFKA-9471: --- [~vitojeng] Please let me know if I should proceed with this or, do you plan to include the exception throwing in KIP-216 ? > Throw exception for DEAD StreamThread.State > --- > > Key: KAFKA-9471 > URL: https://issues.apache.org/jira/browse/KAFKA-9471 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > > In StreamThreadStateStoreProvider we have: > {code} > if (streamThread.state() == StreamThread.State.DEAD) { > return Collections.emptyList(); > {code} > If user cannot retry anymore, we should throw exception which is handled in > the else block. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9471) Throw exception for DEAD StreamThread.State
[ https://issues.apache.org/jira/browse/KAFKA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022968#comment-17022968 ] Vito Jeng commented on KAFKA-9471: -- [~yuzhih...@gmail.com] Yes. Currently, *shouldAllowToQueryAfterThreadDied()* would be fail when InvalidStateStoreException thrown. This test method also should be update, IMO. I notice this during KIP-216 implementation, too, but my PR is not yet completed. > Throw exception for DEAD StreamThread.State > --- > > Key: KAFKA-9471 > URL: https://issues.apache.org/jira/browse/KAFKA-9471 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > > In StreamThreadStateStoreProvider we have: > {code} > if (streamThread.state() == StreamThread.State.DEAD) { > return Collections.emptyList(); > {code} > If user cannot retry anymore, we should throw exception which is handled in > the else block. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9471) Throw exception for DEAD StreamThread.State
[ https://issues.apache.org/jira/browse/KAFKA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022614#comment-17022614 ] Matthias J. Sax commented on KAFKA-9471: Btw: we plan to rework some part of the API and also how IQ works internally via https://issues.apache.org/jira/browse/KAFKA-9445 (that is related to https://issues.apache.org/jira/browse/KAFKA-6144) – hence, all those efforts should be synchronized. \cc [~NaviBrar] [~vvcephei] [~vinothchandar] > Throw exception for DEAD StreamThread.State > --- > > Key: KAFKA-9471 > URL: https://issues.apache.org/jira/browse/KAFKA-9471 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > > In StreamThreadStateStoreProvider we have: > {code} > if (streamThread.state() == StreamThread.State.DEAD) { > return Collections.emptyList(); > {code} > If user cannot retry anymore, we should throw exception which is handled in > the else block. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9471) Throw exception for DEAD StreamThread.State
[ https://issues.apache.org/jira/browse/KAFKA-9471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022595#comment-17022595 ] Ted Yu commented on KAFKA-9471: --- [~vitojeng] Looks like the following query depends on the empty collection for DEAD state: {code} @Test public void shouldAllowToQueryAfterThreadDied() throws Exception { {code} It fails when exception is thrown. What do you think ? > Throw exception for DEAD StreamThread.State > --- > > Key: KAFKA-9471 > URL: https://issues.apache.org/jira/browse/KAFKA-9471 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Minor > > In StreamThreadStateStoreProvider we have: > {code} > if (streamThread.state() == StreamThread.State.DEAD) { > return Collections.emptyList(); > {code} > If user cannot retry anymore, we should throw exception which is handled in > the else block. -- This message was sent by Atlassian Jira (v8.3.4#803005)