[jira] [Commented] (KAFKA-9540) Application getting "Could not find the standby task 0_4 while closing it" error
[ https://issues.apache.org/jira/browse/KAFKA-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038868#comment-17038868 ] Bruno Cadonna commented on KAFKA-9540: -- [~ableegoldman] [~guozhang] Can we close this ticket? > Application getting "Could not find the standby task 0_4 while closing it" > error > > > Key: KAFKA-9540 > URL: https://issues.apache.org/jira/browse/KAFKA-9540 > Project: Kafka > Issue Type: Bug > Components: streams >Affects Versions: 2.4.0, 2.5.0 >Reporter: Badai Aqrandista >Priority: Minor > Fix For: 2.4.1 > > > Because of this the following line, there is a possibility that some standby > tasks might not be created: > https://github.com/apache/kafka/blob/2.4.0/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java#L436 > Then causing this line to not adding the task to standby task list: > https://github.com/apache/kafka/blob/2.4.0/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java#L299 > But this line assumes that all standby tasks are to be created and add it to > the standby list: > https://github.com/apache/kafka/blob/2.4.0/streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java#L168 > This results in user getting this error message on the next > PARTITION_ASSIGNMENT state: > {noformat} > Could not find the standby task 0_4 while closing it > (org.apache.kafka.streams.processor.internals.AssignedStandbyTasks:74) > {noformat} > But the harm caused by this issue is minimal: No standby task for some > partitions. And it is recreated on the next rebalance anyway. So, I suggest > lowering this message to WARN. Or probably check to WARN when standby task > could not be created. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9540) Application getting "Could not find the standby task 0_4 while closing it" error
[ https://issues.apache.org/jira/browse/KAFKA-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034918#comment-17034918 ] ASF GitHub Bot commented on KAFKA-9540: --- guozhangwang commented on pull request #8092: KAFKA-9540: Move "Could not find the standby task while closing it" log to debug level URL: https://github.com/apache/kafka/pull/8092 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Application getting "Could not find the standby task 0_4 while closing it" > error > > > Key: KAFKA-9540 > URL: https://issues.apache.org/jira/browse/KAFKA-9540 > Project: Kafka > Issue Type: Bug > Components: streams >Reporter: Badai Aqrandista >Priority: Minor > > Because of this the following line, there is a possibility that some standby > tasks might not be created: > https://github.com/apache/kafka/blob/2.4.0/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java#L436 > Then causing this line to not adding the task to standby task list: > https://github.com/apache/kafka/blob/2.4.0/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java#L299 > But this line assumes that all standby tasks are to be created and add it to > the standby list: > https://github.com/apache/kafka/blob/2.4.0/streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java#L168 > This results in user getting this error message on the next > PARTITION_ASSIGNMENT state: > {noformat} > Could not find the standby task 0_4 while closing it > (org.apache.kafka.streams.processor.internals.AssignedStandbyTasks:74) > {noformat} > But the harm caused by this issue is minimal: No standby task for some > partitions. And it is recreated on the next rebalance anyway. So, I suggest > lowering this message to WARN. Or probably check to WARN when standby task > could not be created. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9540) Application getting "Could not find the standby task 0_4 while closing it" error
[ https://issues.apache.org/jira/browse/KAFKA-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034911#comment-17034911 ] Sophie Blee-Goldman commented on KAFKA-9540: Hey [~badai], thanks for the ticket. Your analysis is correct that this should not be logged as an error, since the cause is a completely valid situation: a standby task is not created if there are no state stores for it to actually work on. That particular standby task will actually never get created, so whichever thread ends up with this task will always hit this upon closing it. It's probably ok to go all the way down to debug, since warn might still suggest to users that something is wrong. I think this is actually fixed in trunk already due to some significant refactoring of the task management code. But I can quick together a quick PR to bump down the log level on 2.4/2.5 (won't make it into 2.5.0 but may get into 2.4.1) Of course the real fix would be for the assignor to be smart enough not to assign these ghost standbys to begin with. We should be able to fix that up as part of KIP-441 > Application getting "Could not find the standby task 0_4 while closing it" > error > > > Key: KAFKA-9540 > URL: https://issues.apache.org/jira/browse/KAFKA-9540 > Project: Kafka > Issue Type: Bug > Components: streams >Reporter: Badai Aqrandista >Priority: Minor > > Because of this the following line, there is a possibility that some standby > tasks might not be created: > https://github.com/apache/kafka/blob/2.4.0/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java#L436 > Then causing this line to not adding the task to standby task list: > https://github.com/apache/kafka/blob/2.4.0/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java#L299 > But this line assumes that all standby tasks are to be created and add it to > the standby list: > https://github.com/apache/kafka/blob/2.4.0/streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java#L168 > This results in user getting this error message on the next > PARTITION_ASSIGNMENT state: > {noformat} > Could not find the standby task 0_4 while closing it > (org.apache.kafka.streams.processor.internals.AssignedStandbyTasks:74) > {noformat} > But the harm caused by this issue is minimal: No standby task for some > partitions. And it is recreated on the next rebalance anyway. So, I suggest > lowering this message to WARN. Or probably check to WARN when standby task > could not be created. -- This message was sent by Atlassian Jira (v8.3.4#803005)