[jira] [Updated] (KAFKA-10673) ConnectionQuotas should cache interbroker listener name
[ https://issues.apache.org/jira/browse/KAFKA-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mao updated KAFKA-10673: -- Description: ConnectionQuotas.protectedListener calls config.interBrokerListenerName. This is a surprisingly expensive call that creates a copy of all properties set on the config. Given that this method is called multiple times per connection created, this is not really ideal. Profile attached showing allocations in protectedListener() was: ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. This is a surprisingly expensive call that creates a copy of all properties set on the config. Given that this method is called multiple times per connection created, this is not really ideal. Profile attached showing allocations in `protectedListener` > ConnectionQuotas should cache interbroker listener name > --- > > Key: KAFKA-10673 > URL: https://issues.apache.org/jira/browse/KAFKA-10673 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 2.7.0 >Reporter: David Mao >Assignee: David Mao >Priority: Minor > Fix For: 2.8.0 > > Attachments: Screen Shot 2020-11-03 at 8.34.48 PM.png > > > ConnectionQuotas.protectedListener calls config.interBrokerListenerName. This > is a surprisingly expensive call that creates a copy of all properties set on > the config. Given that this method is called multiple times per connection > created, this is not really ideal. > > Profile attached showing allocations in protectedListener() > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KAFKA-10673) ConnectionQuotas should cache interbroker listener name
[ https://issues.apache.org/jira/browse/KAFKA-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mao updated KAFKA-10673: -- Description: ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. This is a surprisingly expensive call that creates a copy of all properties set on the config. Given that this method is called multiple times per connection created, this is not really ideal. Profile attached showing allocations in `protectedListener` was: ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. This is a surprisingly expensive call that creates a copy of all properties set on the config. Given that this method is called multiple times per connection created, this is not really ideal. Profile attached showing allocations. Allocations in Acceptor.run() made up 2% of the allocations on a fairly busy cluster. > ConnectionQuotas should cache interbroker listener name > --- > > Key: KAFKA-10673 > URL: https://issues.apache.org/jira/browse/KAFKA-10673 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 2.7.0 >Reporter: David Mao >Assignee: David Mao >Priority: Minor > Fix For: 2.8.0 > > Attachments: Screen Shot 2020-11-03 at 8.34.48 PM.png > > > ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. > This is a surprisingly expensive call that creates a copy of all properties > set on the config. Given that this method is called multiple times per > connection created, this is not really ideal. > > Profile attached showing allocations in `protectedListener` > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KAFKA-10673) ConnectionQuotas should cache interbroker listener name
[ https://issues.apache.org/jira/browse/KAFKA-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mao updated KAFKA-10673: -- Description: ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. This is a surprisingly expensive call that creates a copy of all properties set on the config. Given that this method is called multiple times per connection created, this is not really ideal. Profile attached showing allocations. Allocations in Acceptor.run() made up 2% of the allocations on a fairly busy cluster. was: !Screen Shot 2020-11-03 at 8.34.48 PM.png! ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. This is a surprisingly expensive call that creates a copy of all properties set on the config. Given that this method is called multiple times per connection created, this is not really ideal. Profile attached showing allocations. Allocations in Acceptor.run() made up 2% of the allocations on a fairly busy cluster. > ConnectionQuotas should cache interbroker listener name > --- > > Key: KAFKA-10673 > URL: https://issues.apache.org/jira/browse/KAFKA-10673 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 2.7.0 >Reporter: David Mao >Assignee: David Mao >Priority: Minor > Fix For: 2.8.0 > > Attachments: Screen Shot 2020-11-03 at 8.34.48 PM.png > > > ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. > This is a surprisingly expensive call that creates a copy of all properties > set on the config. Given that this method is called multiple times per > connection created, this is not really ideal. > > Profile attached showing allocations. Allocations in Acceptor.run() made up > 2% of the allocations on a fairly busy cluster. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KAFKA-10673) ConnectionQuotas should cache interbroker listener name
[ https://issues.apache.org/jira/browse/KAFKA-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mao updated KAFKA-10673: -- Description: !Screen Shot 2020-11-03 at 8.34.48 PM.png! ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. This is a surprisingly expensive call that creates a copy of all properties set on the config. Given that this method is called multiple times per connection created, this is not really ideal. Profile attached showing allocations. Allocations in Acceptor.run() made up 2% of the allocations on a fairly busy cluster. was: ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. This is a surprisingly expensive call that creates a copy of all properties set on the config. Given that this method is called multiple times per connection created, this is not really ideal. Profile attached showing allocations. Allocations in Acceptor.run() made up 2% of the allocations on a fairly busy cluster. > ConnectionQuotas should cache interbroker listener name > --- > > Key: KAFKA-10673 > URL: https://issues.apache.org/jira/browse/KAFKA-10673 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 2.7.0 >Reporter: David Mao >Assignee: David Mao >Priority: Minor > Fix For: 2.8.0 > > Attachments: Screen Shot 2020-11-03 at 8.34.48 PM.png > > > !Screen Shot 2020-11-03 at 8.34.48 PM.png! ConnectionQuotas.protectedListener > calls `config.interBrokerListenerName`. This is a surprisingly expensive call > that creates a copy of all properties set on the config. Given that this > method is called multiple times per connection created, this is not really > ideal. > > Profile attached showing allocations. Allocations in Acceptor.run() made up > 2% of the allocations on a fairly busy cluster. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KAFKA-10673) ConnectionQuotas should cache interbroker listener name
[ https://issues.apache.org/jira/browse/KAFKA-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mao updated KAFKA-10673: -- Attachment: Screen Shot 2020-11-03 at 8.34.48 PM.png > ConnectionQuotas should cache interbroker listener name > --- > > Key: KAFKA-10673 > URL: https://issues.apache.org/jira/browse/KAFKA-10673 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 2.7.0 >Reporter: David Mao >Assignee: David Mao >Priority: Minor > Fix For: 2.8.0 > > Attachments: Screen Shot 2020-11-03 at 8.34.48 PM.png > > > ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. > This is a surprisingly expensive call that creates a copy of all properties > set on the config. Given that this method is called multiple times per > connection created, this is not really ideal. > > Profile attached showing allocations. Allocations in Acceptor.run() made up > 2% of the allocations on a fairly busy cluster. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KAFKA-10673) ConnectionQuotas should cache interbroker listener name
[ https://issues.apache.org/jira/browse/KAFKA-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mao updated KAFKA-10673: -- Description: ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. This is a surprisingly expensive call that creates a copy of all properties set on the config. Given that this method is called multiple times per connection created, this is not really ideal. Profile attached showing allocations. Allocations in Acceptor.run() made up 2% of the allocations on a fairly busy cluster. was:ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. This is a surprisingly expensive call that creates a copy of all properties set on the config. Given that this method is called multiple times per connection created, this is not really ideal. > ConnectionQuotas should cache interbroker listener name > --- > > Key: KAFKA-10673 > URL: https://issues.apache.org/jira/browse/KAFKA-10673 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 2.7.0 >Reporter: David Mao >Assignee: David Mao >Priority: Minor > Fix For: 2.8.0 > > > ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. > This is a surprisingly expensive call that creates a copy of all properties > set on the config. Given that this method is called multiple times per > connection created, this is not really ideal. > > Profile attached showing allocations. Allocations in Acceptor.run() made up > 2% of the allocations on a fairly busy cluster. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (KAFKA-10673) ConnectionQuotas should cache interbroker listener name
[ https://issues.apache.org/jira/browse/KAFKA-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mao updated KAFKA-10673: -- Priority: Minor (was: Major) > ConnectionQuotas should cache interbroker listener name > --- > > Key: KAFKA-10673 > URL: https://issues.apache.org/jira/browse/KAFKA-10673 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 2.7.0 >Reporter: David Mao >Assignee: David Mao >Priority: Minor > Fix For: 2.8.0 > > > ConnectionQuotas.protectedListener calls `config.interBrokerListenerName`. > This is a surprisingly expensive call that creates a copy of all properties > set on the config. Given that this method is called multiple times per > connection created, this is not really ideal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
