[jira] [Updated] (KAFKA-8040) Streams needs to retry initTransactions

2019-03-08 Thread Matthias J. Sax (JIRA)


 [ 
https://issues.apache.org/jira/browse/KAFKA-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthias J. Sax updated KAFKA-8040:
---
Fix Version/s: (was: 2.3.0)

> Streams needs to retry initTransactions
> ---
>
> Key: KAFKA-8040
> URL: https://issues.apache.org/jira/browse/KAFKA-8040
> Project: Kafka
>  Issue Type: Improvement
>  Components: streams
>Affects Versions: 2.0.0, 2.0.1, 2.1.0, 2.2.0, 2.1.1
>Reporter: John Roesler
>Assignee: John Roesler
>Priority: Critical
> Fix For: 2.2.0, 2.0.2, 2.1.2
>
>
> Following on KAFKA-6446, Streams needs to handle the new behavior.
> `initTxn` can throw TimeoutException now: default `MAX_BLOCK_MS_CONFIG` in 
> producer is 60 seconds, so I ([~guozhang]) think just wrapping it as 
> StreamsException should be reasonable, similar to what we do for 
> `producer#send`'s TimeoutException 
> ([https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java#L220-L225]
>  ).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KAFKA-8040) Streams needs to retry initTransactions

2019-03-08 Thread Matthias J. Sax (JIRA)


 [ 
https://issues.apache.org/jira/browse/KAFKA-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthias J. Sax updated KAFKA-8040:
---
Fix Version/s: (was: 2.2.1)
   2.2.0

> Streams needs to retry initTransactions
> ---
>
> Key: KAFKA-8040
> URL: https://issues.apache.org/jira/browse/KAFKA-8040
> Project: Kafka
>  Issue Type: Improvement
>  Components: streams
>Affects Versions: 2.0.0, 2.0.1, 2.1.0, 2.2.0, 2.1.1
>Reporter: John Roesler
>Assignee: John Roesler
>Priority: Critical
> Fix For: 2.2.0, 2.0.2, 2.3.0, 2.1.2
>
>
> Following on KAFKA-6446, Streams needs to handle the new behavior.
> `initTxn` can throw TimeoutException now: default `MAX_BLOCK_MS_CONFIG` in 
> producer is 60 seconds, so I ([~guozhang]) think just wrapping it as 
> StreamsException should be reasonable, similar to what we do for 
> `producer#send`'s TimeoutException 
> ([https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java#L220-L225]
>  ).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KAFKA-8040) Streams needs to retry initTransactions

2019-03-08 Thread John Roesler (JIRA)


 [ 
https://issues.apache.org/jira/browse/KAFKA-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Roesler updated KAFKA-8040:

Fix Version/s: 2.2.1
   2.1.2
   2.0.2

> Streams needs to retry initTransactions
> ---
>
> Key: KAFKA-8040
> URL: https://issues.apache.org/jira/browse/KAFKA-8040
> Project: Kafka
>  Issue Type: Improvement
>  Components: streams
>Affects Versions: 2.0.0, 2.0.1, 2.1.0, 2.2.0, 2.1.1
>Reporter: John Roesler
>Assignee: John Roesler
>Priority: Critical
> Fix For: 2.0.2, 2.3.0, 2.1.2, 2.2.1
>
>
> Following on KAFKA-6446, Streams needs to handle the new behavior.
> `initTxn` can throw TimeoutException now: default `MAX_BLOCK_MS_CONFIG` in 
> producer is 60 seconds, so I ([~guozhang]) think just wrapping it as 
> StreamsException should be reasonable, similar to what we do for 
> `producer#send`'s TimeoutException 
> ([https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java#L220-L225]
>  ).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (KAFKA-8040) Streams needs to retry initTransactions

2019-03-04 Thread John Roesler (JIRA)


 [ 
https://issues.apache.org/jira/browse/KAFKA-8040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Roesler updated KAFKA-8040:

Description: 
Following on KAFKA-6446, Streams needs to handle the new behavior.

`initTxn` can throw TimeoutException now: default `MAX_BLOCK_MS_CONFIG` in 
producer is 60 seconds, so I ([~guozhang]) think just wrapping it as 
StreamsException should be reasonable, similar to what we do for 
`producer#send`'s TimeoutException 
([https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java#L220-L225]
 ).

 

  was:
Following on KAFKA-7763, Streams needs to handle the new behavior.

See also [https://github.com/apache/kafka/pull/6066]

Streams code (StreamTask.java) needs to be modified to handle the new exception.

Also, from another upstream change, `initTxn` can also throw TimeoutException 
now: default `MAX_BLOCK_MS_CONFIG` in producer is 60 seconds, so I think just 
wrapping it as StreamsException should be reasonable, similar to what we do for 
`producer#send`'s TimeoutException 
([https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java#L220-L225]
 ).

 

Note we need to handle in three functions: init/commit/abortTxn.

 

See also https://github.com/apache/kafka/pull/6066#issuecomment-464403448


> Streams needs to retry initTransactions
> ---
>
> Key: KAFKA-8040
> URL: https://issues.apache.org/jira/browse/KAFKA-8040
> Project: Kafka
>  Issue Type: Improvement
>  Components: streams
>Affects Versions: 2.0.0, 2.0.1, 2.1.0, 2.2.0, 2.1.1
>Reporter: John Roesler
>Assignee: John Roesler
>Priority: Critical
> Fix For: 2.3.0
>
>
> Following on KAFKA-6446, Streams needs to handle the new behavior.
> `initTxn` can throw TimeoutException now: default `MAX_BLOCK_MS_CONFIG` in 
> producer is 60 seconds, so I ([~guozhang]) think just wrapping it as 
> StreamsException should be reasonable, similar to what we do for 
> `producer#send`'s TimeoutException 
> ([https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java#L220-L225]
>  ).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)