Re: [PR] [Draft] KAFKA-16764: New consumer should throw InvalidTopicException on poll when invalid topic in metadata [kafka]

[via GitHub]

appchemist commented on code in PR #15961:
URL: https://github.com/apache/kafka/pull/15961#discussion_r1603033581


##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1607,6 +1607,7 @@ private Fetch pollForFetches(Timer timer) {
 wakeupTrigger.clearTask();
 }
 
+metadata.maybeThrowAnyException();

Review Comment:
   @lianetm Based on the feedback in the review, I've developed a proposal for 
using the MetadataUpdater.
   However, test code still needs to be written. I've developed this as a draft 
for now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [Draft] KAFKA-16764: New consumer should throw InvalidTopicException on poll when invalid topic in metadata [kafka]

[via GitHub]

appchemist commented on code in PR #15961:
URL: https://github.com/apache/kafka/pull/15961#discussion_r1603033581


##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1607,6 +1607,7 @@ private Fetch pollForFetches(Timer timer) {
 wakeupTrigger.clearTask();
 }
 
+metadata.maybeThrowAnyException();

Review Comment:
   @lianetm Based on the feedback in the review, I've developed a proposal for 
using the `MetadataUpdater`.
   However, test code still needs to be written. I've developed this as a draft 
for now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [Draft] KAFKA-16764: New consumer should throw InvalidTopicException on poll when invalid topic in metadata [kafka]

[via GitHub]

appchemist commented on code in PR #15961:
URL: https://github.com/apache/kafka/pull/15961#discussion_r1603033581


##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1607,6 +1607,7 @@ private Fetch pollForFetches(Timer timer) {
 wakeupTrigger.clearTask();
 }
 
+metadata.maybeThrowAnyException();

Review Comment:
   @lianetm Based on the feedback in the review, I've developed a proposal for 
using the `MetadataUpdater`.
   However, test code still needs to be written. I've developed this as a draft 
for now
   
   If you have a moment, please take a look



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [Draft] KAFKA-16764: New consumer should throw InvalidTopicException on poll when invalid topic in metadata [kafka]

[via GitHub]

philipnee commented on PR #15961:
URL: https://github.com/apache/kafka/pull/15961#issuecomment-2115931518

   hey @appchemist - let us know if this is ready for review. thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [Draft] KAFKA-16764: New consumer should throw InvalidTopicException on poll when invalid topic in metadata [kafka]

[via GitHub]

appchemist commented on PR #15961:
URL: https://github.com/apache/kafka/pull/15961#issuecomment-2116554582

   @philipnee I got it. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [Draft] KAFKA-16764: New consumer should throw InvalidTopicException on poll when invalid topic in metadata [kafka]

[via GitHub]

appchemist commented on PR #15961:
URL: https://github.com/apache/kafka/pull/15961#issuecomment-2117739675

   @lianetm & @philipnee PTAL
   
   `testSubscriptionOnInvalidTopic` is still disabled for new consumer.
   I couldn't make the changes because `MockMetadataUpdater` is being used 
internally instead of `MetadataUpdater`.
   So I only added unittest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [Draft] KAFKA-16764: New consumer should throw InvalidTopicException on poll when invalid topic in metadata. [kafka]

[via GitHub]

appchemist commented on PR #15961:
URL: https://github.com/apache/kafka/pull/15961#issuecomment-2120213471

   @lianetm & @philipnee If you have a moment, Please take a look
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org